[Dev] ShapeShift Implimentation

Wellenreiter

…

To be honest I’m not sure how this would work.

We would prefer it to be modular. Essentially, it needs to be optional.

If we can build the under laying structure for api based modules into the new core (if that’s how this works) we can make this the first module to be developed.

I also think this raises the question of having the option of self updating wallets and self updating modules. Or at least the ability to push the updates from within the Qt that way there’s need to manually update wallets etc. Can this be achieved at the same time. Is there a way that software could self update via github?

I think that is where we should start.

How could it work?

we could compile the modules into libraries and place them into a known directory.

At startup the clients scans for libraries and adds these or better the contained modules to the GUI. A pre-defined function common in all libraries could return the menu-items and other stuff needed.

Self updating wallets

For Linux pre-compiled binaries I would leave that to the operating system update function. Most Linux distributions have an auto-update function, where the repositories of installed programs are scanned for updates regulary and either automated or user triggered updates are possible. New or changed dependencies - e.g. change db4 -> db5 in the 0.8.x core - are solved automatically

Auto-update from Github is close to impossible, as only the source code is available and the user needs to compile the binaries locally

kris_davison

Unless we stored the compiled binaries in a separate github?

Wellenreiter

Unless we stored the compiled binaries in a separate github?

still would not solve the dependencies problem

kris_davison

True

https://www.youtube.com/watch?v=4z7U4kU4NJA

How could it work?

we could compile the modules into libraries and place them into a known directory.

At startup the clients scans for libraries and adds these or better the contained modules to the GUI. A pre-defined function common in all libraries could return the menu-items and other stuff needed.

Self updating wallets

For Linux pre-compiled binaries I would leave that to the operating system update function. Most Linux distributions have an auto-update function, where the repositories of installed programs are scanned for updates regulary and either automated or user triggered updates are possible. New or changed dependencies - e.g. change db4 -> db5 in the 0.8.x core - are solved automatically

Auto-update from Github is close to impossible, as only the source code is available and the user needs to compile the binaries locally

Ok then. Sounds like somewhere to start. Shame about the auto updating thing. Maybe best to not worry about that at this given point in time.

But yeah, In regards to the modules, that sounds like a great starting point. There’s a lot to brainstorm first but this will work out.

lizhi

Today, Shapeshift.io invited us to test. include FTC_BTC and FTC_LTC

Who can test it ?

Hopefully we will have one of their devs on here soon so they will be able to discuss with us the potentials for SS and also Lens.

Once we can have a solid discussion we will see exactly how we shall go about this, but this is now a current project.

Multisig is well under way, stealth address implementation will begin in about a month or so which at the same time, 2FA should be in development also.

lizhi

I’m working for the api of shapeshift . But Now I find that their services are not stable.May be busy or error or expired.

kris_davison

It looks like there is a timeout of about 15 seconds or so for the exchange rate. I think there is something on the API where you can check how long is left until the end of this timeframe.

lizhi

nice , I finish a transaction with shapeshift’s API.

I post a request ,then get a json data from API.

QString jsonData="{\"withdrawal\":\"17GZr6RaDfUt2HXRVkmJgVhXKdkej1VMb9\",\"pair\":\"ftc_btc\",\"returnAddress\":\"71whQbi6pq2aCSvMvcTKCcTZDfAbUvf2Se\"}";

After I send 3 FTC to shapeshift, I receive my bitcoin .:)

{"status":"complete","address":"6ukBJuHg9s7T1wzeJctvy1pAZ2i2Fv7WfN","withdraw":"17GZr6RaDfUt2HXRVkmJgVhXKdkej1VMb9","incomingCoin":3,"incomingType":"FTC","outgoingCoin":"0.00017887","outgoingType":"BTC","transaction":"bdc60131a810f950c15895a54582854f8ce5068a61763b85fbd7885f5af54dd1"}

Hello everyone!

We found this thread and wanted to let you know that ShapeShift is happy to support this project in any way possible.

One of our lead devs will watch this thread and will be available for questions and contribution. Once this plugin is finished, we’ll be happy to promote it throughout Bitcoinland and get you guys some publicity.

We think it’s an awesome idea, so please stay in contact and let us know what we can do to help. Also, feel free to email us at mail at shapeshift.io

Cheers!

Beorn & the ShapeShift team

MrWyrm

Thanks! That’s above and beyond.

Oh wow!

Couldn’t ask for more ahy!

This is going to be very interesting. Can’t wait to see what we can come up with for everyone.

tmuir12

Once all sorted will this be a plugin?

SO you download and get your wallet running and then yiu can download and install the module if you so desire?

Also should you no longer want the module it needs to be made easy to remove too.

Its a bit above my coding skill, but should we develop a standard on how to install and where to install that all modules adapt to make it easier to allow future modules to be added?

…should we develop a standard on how to install and where to install that all modules adapt to make it easier to allow future modules to be added?

+1.

Very well much yes. That is the core idea of the modules system. It is so we can grow the abilities of the wallet/network without having the users downloads been bigger than necessary.

It needs to be well documented as well to encourage 3rd party developers.

lizhi

Tonight,I impliment shapeshift. I develope a plugin for feathercoin core wallet. Wallet use their api, able to complete the transaction.

I found that the normal trading is no problem in today’s test, but “Fixed Amount Transaction” can not work. shapeshift return deposit.

A Normal Transaction :success

A Fixed Amount Transaction: failed

Receive Data from API:

{"success":{"pair":"ftc_btc","withdrawal":"17GZr6RaDfUt2HXRVkmJgVhXKdkej1VMb9","withdrawalAmount":"0.0003","deposit":"72qWqXhgDTXy9dY92QQwGXL9LSfb4sDRXD","depositAmount":"7.97130331","expiration":1416056746850,"quotedRate":"0.00005018","returnAddress":"71whQbi6pq2aCSvMvcTKCcTZDfAbUvf2Se"}}

mirrax

Lizhi, you are unbelievable treasure of Feathercoin.

Very good work! Again…

Lizhi - very awesome! Regarding the Fixed Amount transaction, there are two possible causes of failure.

The amount was not precise (perhaps your wallet took out a fee or there was some other error with the amount
ShapeShift received your deposit after the time expired (fixed amount transactions guarantee a fixed rate and thus have to limit the time window).

Are you not able to get any Fixed Amount transaction to work properly, even addressing the above issues?

MrWyrm

Lizhi, you are unbelievable treasure of Feathercoin.

Very good work! Again…

I second this. :)