[Dev] ShapeShift Implimentation

tmuir12

Once all sorted will this be a plugin?

SO you download and get your wallet running and then yiu can download and install the module if you so desire?

Also should you no longer want the module it needs to be made easy to remove too.

Its a bit above my coding skill, but should we develop a standard on how to install and where to install that all modules adapt to make it easier to allow future modules to be added?

…should we develop a standard on how to install and where to install that all modules adapt to make it easier to allow future modules to be added?

+1.

Very well much yes. That is the core idea of the modules system. It is so we can grow the abilities of the wallet/network without having the users downloads been bigger than necessary.

It needs to be well documented as well to encourage 3rd party developers.

lizhi

Tonight,I impliment shapeshift. I develope a plugin for feathercoin core wallet. Wallet use their api, able to complete the transaction.

I found that the normal trading is no problem in today’s test, but “Fixed Amount Transaction” can not work. shapeshift return deposit.

A Normal Transaction :success

A Fixed Amount Transaction: failed

Receive Data from API:

{"success":{"pair":"ftc_btc","withdrawal":"17GZr6RaDfUt2HXRVkmJgVhXKdkej1VMb9","withdrawalAmount":"0.0003","deposit":"72qWqXhgDTXy9dY92QQwGXL9LSfb4sDRXD","depositAmount":"7.97130331","expiration":1416056746850,"quotedRate":"0.00005018","returnAddress":"71whQbi6pq2aCSvMvcTKCcTZDfAbUvf2Se"}}

mirrax

Lizhi, you are unbelievable treasure of Feathercoin.

Very good work! Again…

Lizhi - very awesome! Regarding the Fixed Amount transaction, there are two possible causes of failure.

The amount was not precise (perhaps your wallet took out a fee or there was some other error with the amount
ShapeShift received your deposit after the time expired (fixed amount transactions guarantee a fixed rate and thus have to limit the time window).

Are you not able to get any Fixed Amount transaction to work properly, even addressing the above issues?

MrWyrm

Lizhi, you are unbelievable treasure of Feathercoin.

Very good work! Again…

I second this. :)

lizhi

Lizhi - very awesome! Regarding the Fixed Amount transaction, there are two possible causes of failure.

The amount was not precise (perhaps your wallet took out a fee or there was some other error with the amount

ShapeShift received your deposit after the time expired (fixed amount transactions guarantee a fixed rate and thus have to limit the time window).

Are you not able to get any Fixed Amount transaction to work properly, even addressing the above issues?

Today , I will test Fixed Amount transaction again.

kris_davison

This is amazing work lizhi.

it brings so much power to the Feathercoin wallet.

in reality people do what this kind of functionality

lizhi

I hope feathercoin trading easy and fast with more ways.

lizhi

Hi guy, I hope our wallet support shift to bitcoin,litecoin,dogecoin,blackcoin. this is enough?

kris_davison

I think this should be fine for now :)

mirrax

I am sure LTC/DOGE crew will be crying tears of happines. lol

Seriously I miss NMC, PPC and DRK.

The online platform is awesomly simple

If the Qt port works just as well, this will be so freaking amazing…

I’m unpinning this. Discussion on this can continue here if everyone is ok with that - https://forum.feathercoin.com/index.php?/topic/8018-dev-feathercoin-core-093-alpha-release/

Re-Pinning this!

Never mind. Its already been re pinned

MrWyrm

Obvious bump is obvious.

Double bump as priorities should be prioritised.

mirrax

@Guest be aware of shapeshift phishing:

https://shapeshift.io/site/blog/2016/01/18/please-read-note-scam-social-media-accounts-and-website