[Dev] Release Candidate Feathercoin 0.9.3.2 - Check List

Wellenreiter

Please create pulls requests toward the feathercoin main repository for all changes so we can include them into the 0.9.3.2 branch and check for conflicts.

wrapper

I’'ll try and find out what creating a pull request is, I read the procedure was to email the maintainer you have a pull they might want, as I am not the FTC maintainer (still learning).

I’m trying to add a simple FTC build example in the 0.9.3.2 Doc readme, that includes the extra dependencies and settings needed to compile from source / PPA.

However, still not been able to set up a build from scratch from instructions for 0.9.3.2 on Ubuntu 16.04 , - so they need build testing by someone else before pulling.

Wellenreiter

@wrapper said:

I’'ll try and find out what creating a pull request is, I read the procedure was to email the maintainer you have a pull they might want, as I am not the FTC maintainer (still learning).

I’m trying to add a simple FTC build example in the 0.9.3.2 Doc readme, that includes the extra dependencies and settings needed to compile from source / PPA.

However, still not been able to set up a build from scratch from instructions for 0.9.3.2 on Ubuntu 16.04 , - so they need build testing by someone else before pulling.

creating a pull request is more or less easy.

commit and push your changes to github
access your fork on github via the web interface
select the branch you wher eworking on
- you should see a button 'new pull request> just at the right side of the branch name
- there should be a lit of you last changes near the top of the page together with a ‘create pull request’ button

When creating a pull request, be careful that you compare in the right direction.

the base fork should be ‘Feathercoin/0.9.3.2’ and the head fork <your repository>/0.9.3.2

When creating the system generates the notification emails

wrapper

Request for assistance Test and Guide production 0.9.3.2

/ how to compile / program Feathercoin :

Test and comments / improvement ideas for Feathercoin wallet user interface.
Test comments and patches to - Feathercoin Wallet Guide.

If testing on a live system, rename / backup your .feathercoin directory. This prevents problems with your live wallet, tests resync from scratch and provides fresh debug.log files for inspection.

Feathercoin 0.9.3.2 Guide to Features : Github

The Feathercoin help guide is in development, the latest version of the can be cloned from :

https://github.com/wrapperband/FeathercoinWalletGuide.git

How to Build wallet Test version :

Install Virtual Machine with Ubuntu 16.04

git clone https://github.com/Feathercoin/Feathercoin.git
git checkout 0.9.3.2

Install dependencies :

https://github.com/Feathercoin/Feathercoin/tree/0.9.3.2/doc

Build cycle

make clean
./autogen.sh
autoupdate
./configure  --enable-tests=no --with-gui=qt5 --enable-upnp-default --with-qrcode=no 
make

How to make UI changes

You can make updates to the interface, by installing and IDE.
Qt Creator is an easy to use IDE.
Simply open the interface files stored in Feathercoin/src/qt/forms as *.ui files.

How to save your changes to Github

Register with Github, it is free for open source use.
Fork the Feathercoin project to your own repository
https://Feathercoin/Feathercoin
Clone your fork to your own PC
Make changes to Code - Copy changed FTC code to a separate Build directory
git checkout 0.9.3.2
Build code cycle

how to run built code
cd Feathercoin
cd src
cd qt

     ./feathercoin-qt

AcidD

EDIT : Removed some nonsense I was talking and fixed the command so there’s no confusion.
Build Instructions further down…: http://forum.feathercoin.com/topic/8570/dev-release-candidate-feathercoin-0-9-3-2-check-list/34


  OBJCXXLD feathercoin-qt
libbitcoinqt.a(libbitcoinqt_a-snapwidget.o): In function `SnapWidget::on_snapButton_clicked()':
/home/aciddude/FTC0932/Feathercoin/src/qt/snapwidget.cpp:71: undefined reference to `zxing::String::getText[abi:cxx11]() const'
collect2: error: ld returned 1 exit status
Makefile:1203: recipe for target 'feathercoin-qt' failed
make[5]: *** [feathercoin-qt] Error 1

After some googling I found this:
http://stackoverflow.com/questions/30124264/undefined-reference-to-googleprotobufinternalempty-string-abicxx11

So I rebuilt Libzxing from this guy
https://github.com/glassechidna/zxing-cpp

and my build command for libzxing was

export CXXFLAGS="-fPIC"
cmake -G “Unix Makefiles” -DCMAKE_BUILD_TYPE=Release ..
sudo make 
sudo make install

I then copied the libzxing files to the Feathercoin/src/ folder and continued my make. It compiles and I can see QRcodes :-)

AcidD

So I’ve tested some of this on 0.9.3.2 Ubuntu 16.04 .

@wrapper said:

https://github.com/wrapperband/Feathercoin/commits/0.9.3.2

aboutdialog.ui
https://github.com/wrapperband/Feathercoin/commit/f0c6f462085db7534470188d86448c0dd4c0e012
Looks good.

debugdialog.ui
https://github.com/wrapperband/Feathercoin/commit/e6e74b08695852dfe0506f2f031df78fee23b8db
Looks good.

paperwalletdialog.ui
https://github.com/wrapperband/Feathercoin/commit/d38d7f9345be22cb772ce58bdad96da9e48f23bc
I was able to print a paper wallet. (print to PDF)
I was not able to input anything into the public key space nor was I able to delete what was there.
I was able to generate new addresses and make and print multiple wallets

AcidD

0.9.3.2 wallet fully synced in 2.5 hours.

Wallet sends and receives Feathercoins just fine :-)

here’s me tipping @Wellenreiter using 0.9.3.2
http://explorer.feathercoin.com/tx/ae7a76ea80f7f8b41c8be3fcb1850e7e0c4bf8d5cc2d9510740fc563107c0097#o0

I also did a comment to @Wellenreiter in this tx
http://explorer.feathercoin.com/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7#o1

Edit…I now know how to check for comments on the FTC block chain.

On my block explorer can see the transaction and I can copy and paste the OP_RETURN which was
49207265737065637420796f757220776f726b206475646521

http://fsight.chain.tips/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7

Hex to Ascii on OP_RETURN 49207265737065637420796f757220776f726b206475646521 = I respect your work dude!

AmDD

@aciddude 2.5 hours?? Very nice!!

wrapper

@Aciddude

I’ve added your zxing “build from source instructions” to an updated FTC wallet install from source guide in my [Dev] version of 0.9.3.2.

https://github.com/wrapperband/Feathercoin/tree/0.9.3.2/doc

Wellenreiter

@aciddude Great :)

So I rebuilt Libzxing from this guy
https://github.com/glassechidna/zxing-cpp

I will use that version of zxing to build my packages :)

Wellenreiter

@aciddude said:

0.9.3.2 wallet fully synced in 2.5 hours.

Wallet sends and receives Feathercoins just fine :-)

here’s me tipping @Wellenreiter using 0.9.3.2
http://explorer.feathercoin.com/tx/ae7a76ea80f7f8b41c8be3fcb1850e7e0c4bf8d5cc2d9510740fc563107c0097#o0

I also did a comment to @Wellenreiter in this tx
http://explorer.feathercoin.com/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7#o1

Edit…I now know how to check for comments on the FTC block chain.

On my block explorer can see the transaction and I can copy and paste the OP_RETURN which was
49207265737065637420796f757220776f726b206475646521

http://fsight.chain.tips/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7

Hex to Ascii on OP_RETURN 49207265737065637420796f757220776f726b206475646521 = I respect your work dude!

We should try to find a way to detect commends in the BC, do the conversion automatically and display the comment in the GUI

AcidD

@Wellenreiter said:

@aciddude said:

0.9.3.2 wallet fully synced in 2.5 hours.

Wallet sends and receives Feathercoins just fine :-)

here’s me tipping @Wellenreiter using 0.9.3.2
http://explorer.feathercoin.com/tx/ae7a76ea80f7f8b41c8be3fcb1850e7e0c4bf8d5cc2d9510740fc563107c0097#o0

I also did a comment to @Wellenreiter in this tx
http://explorer.feathercoin.com/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7#o1

Edit…I now know how to check for comments on the FTC block chain.

On my block explorer can see the transaction and I can copy and paste the OP_RETURN which was
49207265737065637420796f757220776f726b206475646521

http://fsight.chain.tips/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7

Hex to Ascii on OP_RETURN 49207265737065637420796f757220776f726b206475646521 = I respect your work dude!

We should try to find a way to detect commends in the BC, do the conversion automatically and display the comment in the GUI

I thought about this last night…it shouldnt be too hard with the Bitpay / Insight API - the OP_Return is already printed so some simple Javascript or PHP would do…

wrapper

Re : Feathercoin Wallet Advanced Features - Comments :

That’s great work. I can update the comment section of the guide with some help text.

We should ask @Lizhi, it may be a simple matter to “Report through” you comments
plus we need a simple comment decoder method.
Could the search for stealth coins be cloned to search for comments?

Without racking up dead coals, Is there any bounties left?.

wrapper

@Aciddude and I are still having trouble reproducing the 0.9.3.2 build, from documentation.

Seems to be a problem making a compatible zxing-cpp library (Qt5 issue).

I’ve posted an issue at zxing-cpp which we use to do the QR codes in the wallet. It contains more detail of the mechanics of it.

Manually-specified variables were not used by the project:
https://github.com/glassechidna/zxing-cpp/issues/43

zxing-cpp does seem to be a "live project2, so I don’t think we need to look for a new library just yet. We’ll see how much hair Aciddude and I have left after tonight :)

wrapper

Re : Reproducable build documents for 16.04

I found these error messages mixed in all the ./configure warnings, fresh build, 16.04, zxing files from /usr/include/zxing after PPA install.

  In file included from qimagesource.h:6:0,
             from qimagesource.cpp:1:
      ../../src/zxing/LuminanceSource.h: In member function ‘virtual zxing::ArrayRef<char> 
  QImageLuminanceSource::getMatrix() const’:
  ../../src/zxing/LuminanceSource.h:31:13: error: ‘const int zxing::LuminanceSource::width’ is private
  const int width;
         ^

etc …

lizhi

I push two patchs to 0.9.3.2 branche, should copy into master-0.9 .

https://github.com/FeatherCoin/Feathercoin/commit/7b5d133d41fef537a49145346a31b8358d5b83c2
https://github.com/FeatherCoin/Feathercoin/commit/f0229d3371cf2811ded7ad8641c1a1834862c2d9

Wellenreiter

@Lizhi thanks for your work. Did you fix the issue @ghostlander discovered also?
I’ve opened an issue on github, just to be sure, we track that problem.

Also, can you start to add a short description to yout commits in the commit comment and describe the purpose of the commit?
I know it is an overhead, but we need to maintain a release document to keep track of the changes we implement, and adding a meaningfull comment to every commit is a good basis for such a release documentation.

Wellenreiter

Hate to post twice, so please read :
http://forum.feathercoin.com/topic/8545/dev-segregated-witness-and-bip-102/26

wrapper

I have been trying to help Splash with a sync issue, they report having version 0.9.3.2?

Shall I withdraw my push, rebase to your new release and we take 0.9.3.3 beta of the next release? I have a number of further small fixes and a guide in development for that release?

wrapper

@LIzhi
A windows version of 0.9.3.2 appears to have been uploaded to Feathercoin.com 17 days ago?

The forum banner was not updated, no other distro updated etc.Is it causing support sync issues?