[Dev] Release Candidate Feathercoin 0.9.3.2 - Check List

wrapper

@Aciddude

I’ve added your zxing “build from source instructions” to an updated FTC wallet install from source guide in my [Dev] version of 0.9.3.2.

https://github.com/wrapperband/Feathercoin/tree/0.9.3.2/doc

Wellenreiter

@aciddude Great :)

So I rebuilt Libzxing from this guy
https://github.com/glassechidna/zxing-cpp

I will use that version of zxing to build my packages :)

Wellenreiter

@aciddude said:

0.9.3.2 wallet fully synced in 2.5 hours.

Wallet sends and receives Feathercoins just fine :-)

here’s me tipping @Wellenreiter using 0.9.3.2
http://explorer.feathercoin.com/tx/ae7a76ea80f7f8b41c8be3fcb1850e7e0c4bf8d5cc2d9510740fc563107c0097#o0

I also did a comment to @Wellenreiter in this tx
http://explorer.feathercoin.com/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7#o1

Edit…I now know how to check for comments on the FTC block chain.

On my block explorer can see the transaction and I can copy and paste the OP_RETURN which was
49207265737065637420796f757220776f726b206475646521

http://fsight.chain.tips/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7

Hex to Ascii on OP_RETURN 49207265737065637420796f757220776f726b206475646521 = I respect your work dude!

We should try to find a way to detect commends in the BC, do the conversion automatically and display the comment in the GUI

AcidD

@Wellenreiter said:

@aciddude said:

0.9.3.2 wallet fully synced in 2.5 hours.

Wallet sends and receives Feathercoins just fine :-)

here’s me tipping @Wellenreiter using 0.9.3.2
http://explorer.feathercoin.com/tx/ae7a76ea80f7f8b41c8be3fcb1850e7e0c4bf8d5cc2d9510740fc563107c0097#o0

I also did a comment to @Wellenreiter in this tx
http://explorer.feathercoin.com/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7#o1

Edit…I now know how to check for comments on the FTC block chain.

On my block explorer can see the transaction and I can copy and paste the OP_RETURN which was
49207265737065637420796f757220776f726b206475646521

http://fsight.chain.tips/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7

Hex to Ascii on OP_RETURN 49207265737065637420796f757220776f726b206475646521 = I respect your work dude!

We should try to find a way to detect commends in the BC, do the conversion automatically and display the comment in the GUI

I thought about this last night…it shouldnt be too hard with the Bitpay / Insight API - the OP_Return is already printed so some simple Javascript or PHP would do…

wrapper

Re : Feathercoin Wallet Advanced Features - Comments :

That’s great work. I can update the comment section of the guide with some help text.

We should ask @Lizhi, it may be a simple matter to “Report through” you comments
plus we need a simple comment decoder method.
Could the search for stealth coins be cloned to search for comments?

Without racking up dead coals, Is there any bounties left?.

wrapper

@Aciddude and I are still having trouble reproducing the 0.9.3.2 build, from documentation.

Seems to be a problem making a compatible zxing-cpp library (Qt5 issue).

I’ve posted an issue at zxing-cpp which we use to do the QR codes in the wallet. It contains more detail of the mechanics of it.

Manually-specified variables were not used by the project:
https://github.com/glassechidna/zxing-cpp/issues/43

zxing-cpp does seem to be a "live project2, so I don’t think we need to look for a new library just yet. We’ll see how much hair Aciddude and I have left after tonight :)

wrapper

Re : Reproducable build documents for 16.04

I found these error messages mixed in all the ./configure warnings, fresh build, 16.04, zxing files from /usr/include/zxing after PPA install.

  In file included from qimagesource.h:6:0,
             from qimagesource.cpp:1:
      ../../src/zxing/LuminanceSource.h: In member function ‘virtual zxing::ArrayRef<char> 
  QImageLuminanceSource::getMatrix() const’:
  ../../src/zxing/LuminanceSource.h:31:13: error: ‘const int zxing::LuminanceSource::width’ is private
  const int width;
         ^

etc …

lizhi

I push two patchs to 0.9.3.2 branche, should copy into master-0.9 .

https://github.com/FeatherCoin/Feathercoin/commit/7b5d133d41fef537a49145346a31b8358d5b83c2
https://github.com/FeatherCoin/Feathercoin/commit/f0229d3371cf2811ded7ad8641c1a1834862c2d9

Wellenreiter

@Lizhi thanks for your work. Did you fix the issue @ghostlander discovered also?
I’ve opened an issue on github, just to be sure, we track that problem.

Also, can you start to add a short description to yout commits in the commit comment and describe the purpose of the commit?
I know it is an overhead, but we need to maintain a release document to keep track of the changes we implement, and adding a meaningfull comment to every commit is a good basis for such a release documentation.

Wellenreiter

Hate to post twice, so please read :
http://forum.feathercoin.com/topic/8545/dev-segregated-witness-and-bip-102/26

wrapper

I have been trying to help Splash with a sync issue, they report having version 0.9.3.2?

Shall I withdraw my push, rebase to your new release and we take 0.9.3.3 beta of the next release? I have a number of further small fixes and a guide in development for that release?

wrapper

@LIzhi
A windows version of 0.9.3.2 appears to have been uploaded to Feathercoin.com 17 days ago?

The forum banner was not updated, no other distro updated etc.Is it causing support sync issues?

wrapper

Note : Issues found on 0.9.3.1

Alt-F4 Alt-F5 etc does not work for any of the new features on Linux,

Two new features do not have an Alt key allocated, comments / open name.

Quick Fix, remove all Alt keys mapping, too many are used?

Bitmessage does not work on Linux / Ubuntu

Still need update to Wallet on save - If you press Cancel - The wallet should continue to exit

There needs to be “Wallet back-up” options click box, if I want to manually back up when neccesary to turn that option off.

wrapper

I have created a Sourceforge account Feathercoin. I’m just having a look how you upload the builds…

https://sourceforge.net/projects/feathercoin/

AcidD

@wrapper said:

I have created a Sourceforge account Feathercoin. I’m just having a look how you upload the builds…

https://sourceforge.net/projects/feathercoin/

Great! Will this be for new builds moving forward? like 0.9.3.2 and above or will we also include the older builds ?

AcidD

WOOO HOO! I did it again. I can reproduce the 0.9.3.2 build. I gotta get up for work tomorrow but I have all the notes saved.

In short I think all that needs to be done is zxing needs to be compiled again with just this

export CXXFLAGS=-fPIC
env
cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release ..
make
sudo make install

Edit: Love a good screen shot https://i.snag.gy/BcjnXV.jpg

then just compile FTC in the normal way I believe with nothing special there.

AcidD

If anyone wants to replicate

On a fresh Ubuntu 16.04 LTS with the usual things like git and all installed…

Below are my notes… @wrapper :-) Next ?

###Make working directory
mkdir FTC0932
cd FTC0932

## Download Feathercoin  (my clone includes a copy of some of the zxing files...which you will see is useless!!!)
git clone https://github.com/aciddude/Feathercoin.git -b 0.9.3.2
cd Feathercoin/

 
# Install dependancies (some of these are repeats) 
sudo apt-get update
yes | sudo apt-get install autoconf automake debhelper dh-autoreconf
yes | sudo apt-get install qtbase5-dev qttools5-dev-tools
yes | sudo apt-get install libqt5printsupport5 libqt5opengl5-dev
yes | sudo apt-get install libqjson-dev
yes | sudo apt-get install libqt5gui5 libqt5core5a libqt5dbus5
yes | sudo apt-get install libssl-dev
yes | sudo apt-get install libqrencode3 libqrencode-dev pkg-config libprotobuf-dev protobuf-compiler
yes | sudo apt-get install libqrencode-dev pkg-config libprotobuf-dev
yes | sudo apt-get install debhelper
yes | sudo apt-get install libboost-all-dev
yes | sudo apt-get install libmessaging-menu-dev
yes | sudo apt-get install libdb5.3-dev
yes | sudo apt-get install libdb5.3++-dev


### Compile zxing 

###SNEAKY!!! I've included zxing in my Feathercoin/src/ folder...but when i checked the config log on my first build that worked but no qrqodes showed up...

checking whether to build GUI with support for D-Bus... yes
checking whether to build GUI with support for QR codes... no   << Mr.President...What the Hell? 

######During the zxing install you'll see it installs these two files
#  
# Installing: /usr/local/bin/zxing
# Installing: /usr/local/lib/libzxing.a
#
# So the configure file or something looks for thoes and cant find them and then QR codes part doesnt build...

### Build Zxing 
cd ../..
pwd
/home/aciddude

yes | sudo apt-get install cmake


mkdir zxing && cd zxing 
git clone https://github.com/glassechidna/zxing-cpp.git
cd zxing-cpp/
ls
mkdir build
cd build/
export CXXFLAGS="-fPIC"
##verify by running env
env 
"CXXFLAGS=-fPIC
MAIL=/var/mail/aciddude"

### continue with the zxing build 

cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release ..
make && sudo make install

### You then need to go and edit the LuminanceSource.h  file in /usr/local/include/zxing  and change line 30 to "public:"   *instead of private*    if you dont do this FTC will throw an error on compile..


##Compile this thang! 
#####Get back to FTC working directory 

cd ~/FTC0932/Feathercoin/

autoupdate
./autogen.sh
./configure --with-gui=qt5 --enable-tests=no --with-incompatible-bdb --with-qrcode=yes


### At this point you should have a sucessfull config log showing QT will be built with QR code support. 

## Continue with the make and cross your fingers 

make 

# BOOM! 

sudo make install 

feathercoin-qt

Wellenreiter

I’m not sure , if source forge is a step forward. It more or less jas the same functions as github, but with less tools to create and merge branches. I don’t see any advantagfe here. Icd prefer to continue the current way of creating installation packages for the Linux binaries from github and we can add the windows bimaries to the release versions on github for download.

Very important is, that we point to the release section on github and not to the branches directly.
https://github.com/FeatherCoin/Feathercoin/releases

wrapper

@Lizhi @Aciddude @MrWyrm @uncle_muddy

@Wellenreiter SourceForge is complementary to the Github service, it can stores the official Windows and MAC Binaries. We will not be using the other Sourceforge facilities, only the FREE download service to open source projects.

This will also help enforce a simple release procedure and clearly mark, development and stable versions of the wallet, especially as procedures to help others get involved and make sure releases go right.

Github holds the official source code
OpenSuse holds the official Linux builds
SourceForge Official Windows Mac etc Binary builds

We also have :

Feathercoin Name for OpenSuse
use : Would make official builds more obvious and easy to find
workload : would reduce forum link update need in future, more work for Wellenreiter short term

Feathercoin Name for Launchpad
use : Would auto buld Ubuntu, and lead to be software centre, also auto build cross platform snapsnap packages
workload, minimal, OpenSuse is main build mirrors that

I’ll pass on those registrations to a Staff group, so a team can maintain them and spread the work. Mostly is updating at releases, which is worth the effort just for the publicity.

wrapper

@Aciddude Thanks for the massive amount of work, just getting the builds working.

You asked what next?, there a couple of build issues / warnings to look into

Try turning the tests on and see what the situation is with those, why they arn’t working.
Get some more screen shots, (with the improved GUI) of examples and how to use to add to the Wallet guide, to add to 0.9.3.3 / next release, now we can compile it. (awaiting re-base to push to github, shows Test message currently)
Find where the overview and menu background colour is set, to correct for background image inconsistency.

   static CBlockIndex* pblockindexFBBHLast;         unused - testing removed from main.cpp

I couldn’t just delete some unused variables as they were used else where, possibly a revers public to private variable problem, to investigate…

main.h:130:20: warning: ‘OPENNAME_NAME_PREORDER’ defined but not used [-Wunused-variable]
static const char* OPENNAME_NAME_PREORDER=“a”;
^
main.h:131:20: warning: ‘OPENNAME_NAME_REGISTRATION’ defined but not used [-Wunused-variable]
static const char* OPENNAME_NAME_REGISTRATION=“b”;
^
main.h:132:20: warning: ‘OPENNAME_NAME_UPDATE’ defined but not used [-Wunused-variable]
static const char* OPENNAME_NAME_UPDATE=“c”;
^
main.h:133:20: warning: ‘OPENNAME_NAME_TRANSFER’ defined but not used [-Wunused-variable]
static const char* OPENNAME_NAME_TRANSFER=“d”;
^
main.h:134:20: warning: ‘OPENNAME_NAME_RENEWAL’ defined but not used [-Wunused-variable]
static const char* OPENNAME_NAME_RENEWAL=“e”;

walletview.cpp: In member function ‘void WalletView::importWallet(QString)’:
walletview.cpp:351:10: warning: unused variable ‘b’ [-Wunused-variable]
bool b =walletModel->importPrivateKey(privateKey);

transactiondesc.cpp: In static member function ‘static QString TransactionDesc::toHTML(CWallet*, CWalletTx&, int, int)’:
transactiondesc.cpp:228:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int k = 0; k < wtx.vout.size(); ++k)