[Dev] Documenting Feathercoin Specific Software settings - Part 15

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Check block version 2 :: commit

https://github.com/FeatherCoin/Feathercoin/commit/a6e3064572195451ead14e0320f5546734163ad6

src/main.cpp

 -static CBlockIndex* pblockindexFBBHLast;

 +// pblockindexFBBHLast : no longer used 
 +// static CBlockIndex* pblockindexFBBHLast;

Code commented out

 -    if (block.nVersion >= 2)
 +    if (block.nVersion == 2 && block.nTime > nSwitchV2 )

Code replaced

 -    !std::equal(expect.begin(), expect.end(), block.vtx[0].vin[0].scriptSig.begin())) {

 -    return state.DoS(100, error("AcceptBlock() : block height mismatch in coinbase"),

Code removed

 +                !std::equal(expect.begin(), expect.end(), block.vtx[0].vin[0].scriptSig.begin())) 
 +            {
 +                pindex->nStatus |= BLOCK_FAILED_VALID;
 +                LogPrintf("AcceptBlock() block.nVersion=%d,nHeight=%d:\n",block.nVersion,nHeight);
 +                LogPrintf("AcceptBlock() block.vtx[0].vin[0].scriptSig.size()=%d,expect.size()=%d:\n",block.vtx[0].vin[0].scriptSig.size(),expect.size());
 +                return state.DoS(100, error("AcceptBlock() : block nVersion 2 height mismatch in coinbase"),
 +                                 REJECT_INVALID, "bad-cb-height");
 +            }
 +        }
 +    }
 +    
 +    if (block.nVersion == 4 )
 +    {
 +        // if 750 of the last 1,000 blocks are version 2 or greater (51/100 if testnet):
 +        if ((!TestNet() && CBlockIndex::IsSuperMajority(2, pindex->pprev, 750, 1000)) ||
 +            (TestNet() && CBlockIndex::IsSuperMajority(2, pindex->pprev, 51, 100)))
 +        {
 +            CScript expect = CScript() << nHeight;
 +            if (block.vtx[0].vin[0].scriptSig.size() < expect.size() ||
 +                !std::equal(expect.begin(), expect.end(), block.vtx[0].vin[0].scriptSig.begin())) 
 +            {

Code replaced

 +    // 1000个中有750个新版本

comment added … // 750 new versions in 1000

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

int64_t nInterval defined but not used :: commit

https://github.com/FeatherCoin/Feathercoin/commit/4e50ebe4b67d958f4893d568c85e049ae2d2c6ef

src/main.cpp

 // Feathercoin: eHRC at 3rd hard fork

 +//static const int64_t nInterval = nTargetTimespan / nTargetSpacing;

Code commented out

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

dele debug info print :: commit

Delete some debug reports

https://github.com/FeatherCoin/Feathercoin/commits/0.9.6?after=f296bdcef38b8c0770b43d4edc012e8c7434ac49+69

src/stealth.cpp

 +        //printf("StealthSecret(): Q EC_POINT_bn2point failed\n");

 +        //printf("StealthSecret(): Q EC_POINT_bn2point failed\n");

Code removed, commented out

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Test image changes :: commit

Updates to test images, options dialog

https://github.com/FeatherCoin/Feathercoin/commits/0.9.6?after=f296bdcef38b8c0770b43d4edc012e8c7434ac49+69

src/qt/optionsdialog.cpp

 -    ui->thirdPartyTxUrls->setPlaceholderText("http://block.ftc-c.com/tx/%s");

 +    ui->thirdPartyTxUrls->setPlaceholderText("https://explorer.feathercoin.com/chain/Feathercoin/%s");

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

RELEASE is true :: commit

wrapperband commented on fcbf438 on 16 Jul 2016

Re: Software development procedure : Should not have been set true - release engineers responsibility!

Release is only set true when the master build is created, not by the “coder”. There is still a lot of things to pull in to the 0.9.3.2 development, it has not been released.

I now thinking all 0.9.3.2 changes to UI etc be removed from 0.9.3.2. Create 0.9.3.1.1-dev import all changes except “Bridge version” changes. When these changes are finished they can be ported to an accepted “Bridge version” or released as a safer 0.9.3.1.1 maintenance version.

https://github.com/FeatherCoin/Feathercoin/commit/fcbf43833dba99566db04e6a23b1c0afbe9e0a4f

configure.ac

 -define(_CLIENT_VERSION_IS_RELEASE, false)

 +define(_CLIENT_VERSION_IS_RELEASE, true)

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Include test and additional graphics options :: commit

Include test and additional graphics options - development testing GUI. These were Test versions as part of the interface review update. Update UI look and feel.

https://github.com/FeatherCoin/Feathercoin/commit/99ae9046250c8e3edccda3e578025c5ce0008b10

src/qt/res/images/*

 src/qt/res/images/LOGO.png

 src/qt/res/images/LOGO_g_sm.png

 src/qt/res/images/mainbg.grey.1.png

 src/qt/res/images/mainbg.png

 src/qt/res/images/mainbg.shade.2.png

 src/qt/res/images/mainbg.white.3.png

Image files updated. Introduce a common icon theme / look and feel.

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update logo to blue theme :: commit

Update Feathercoin logo to blue theme - as part of development of GUI.

https://github.com/FeatherCoin/Feathercoin/commit/9b49a5d158c600c538545d2be2a3ed93ba8aa748

src/qt/res/images/*

 src/qt/res/images/LOGO.png

Proposed Logo, whilst concept is being accepted / forum input.

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Wallet Overview page with status bar divider :: commit

Wallet Overview page with status bar divider - as part of development of GUI. Difficult rationalization of screen splitting, fixing bugs with background image code, previously imported from Dogecoin. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/44e49ea3f4cd32f14f58785b1572f1c30af8aa53

src/qt/forms/overviewpage.ui

 -   <iconset resource="../feathercoin.qrc">

 +   <iconset resource="../../../../../Feathercoin/src/qt/feathercoin.qrc">

Code replaced

  -          <pixmap resource="../feathercoin.qrc">:/images/mainlogo</pixmap>

 +          <pixmap resource="../../../../../Feathercoin/src/qt/feathercoin.qrc">:/images/mainlogo</pixmap>

Code replaced

 +   <item>
 +    <widget class="Line" name="line_2">
 +     <property name="frameShadow">
 +      <enum>QFrame::Plain</enum>
 +     </property>
 +     <property name="lineWidth">
 +      <number>2</number>
 +     </property>
 +     <property name="orientation">
 +      <enum>Qt::Horizontal</enum>
 +     </property>
 +    </widget>
 +   </item>

Code added

 -  <include location="../feathercoin.qrc"/>

 +  <include location="../../../../../Feathercoin/src/qt/feathercoin.qrc"/>

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Standardise overview status bar divider :: commit

Standardise overview status bar divider to raised shadow - width 1

Wallet Overview page with status bar divider - as part of development of GUI. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/6e9b7e534189f55d762640cfe50e99ca142682ab

src/qt/forms/overviewpage.ui

  -   <iconset resource="../../../../../Feathercoin/src/qt/feathercoin.qrc">

 +   <iconset resource="../feathercoin.qrc">

Code replaced

 -          <pixmap resource="../../../../../Feathercoin/src/qt/feathercoin.qrc">:/images/mainlogo</pixmap>

 +          <pixmap resource="../feathercoin.qrc">:/images/mainlogo</pixmap>

Code replaced

 -      <enum>QFrame::Plain</enum>

 +      <enum>QFrame::Raised</enum>

Code replaced

 -  <include location="../../../../../Feathercoin/src/qt/feathercoin.qrc"/>

+  <include location="../feathercoin.qrc"/>

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Remove code to insert background image in GUI :: commit

Remove code to insert background image in GUI, iterative changes

Wallet Overview page with status bar divider - as part of development of GUI. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/6e9b7e534189f55d762640cfe50e99ca142682ab

src/qt/bitcoingui.cpp

 +  
 +    //    Remove background image 
 +    //    QPalette palette;
 +    //    palette.setBrush(QPalette::Background,QBrush(QPixmap(":/images/mainbg")));
 +    //    this->setPalette(palette);
 +    //    this->setAutoFillBackground(true);

Code commented out, (was to be reviewed without as potential release at time)

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Updated About Box UI layout and FTC Light Blue Bar :: commit

Updated About Box UI layout and FTC Light Blue Bar graduated with white Icon

About dialog box page - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/cc49f52a467267ad772ab73b118f98b56dd176ce

src/qt/forms/aboutdialog.ui

 +     <property name="alignment">
 +      <set>Qt::AlignBottom|Qt::AlignLeading|Qt::AlignLeft</set>
 +     </property>

Code added

 +       <property name="margin">
 +        <number>0</number>
 +       </property>
 +       <property name="indent">
 +        <number>6</number>
 +       </property>

Example of a number of UI and layout tweaks. Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Line Status Bar Divide on the main UI pages :: commit

Include a lineStatusBarDivide on the main UI pages, positioned at bottom,

Multisig dialog page - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/2caed6c745491e97848e1464eaed221bfc2051f8

src/qt/forms/multisigdialog.ui

 -  <layout class="QVBoxLayout" name="verticalLayout" stretch="0,1,0">

 +  <layout class="QVBoxLayout" name="verticalLayout" stretch="0,1,0,0">

Code replaced

 +      <property name="leftMargin">
 +       <number>0</number>
 +      </property>
 +      <property name="topMargin">
 +       <number>0</number>
 +      </property>
 +      <property name="rightMargin">
 +       <number>0</number>
 +      </property>
 +      <property name="bottomMargin">

Example UI code added

Regress transactiondialog lineStatusBarDivider :: commit

https://github.com/FeatherCoin/Feathercoin/commit/875d5b5d1c55315f6709428ec8e57b36d240d629

src/qt/forms/multisigdialog.ui

Removed part of the UI update

 -   <item alignment="Qt::AlignBottom">
 -    <widget class="Line" name="lineStatusBarDivide">
 -     <property name="frameShadow">
 -      <enum>QFrame::Raised</enum>
 -     </property>
 -     <property name="orientation">
 -      <enum>Qt::Horizontal</enum>
 -     </property>
 -    </widget>
 -   </item>

Code removed, UI tweaks

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

First stage updated Icon set to modern feel :: commit

First stage updated Icon set to modern feel and FTC light blue theme

New icon set - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/53617518b20bbd6a5a7b0c31469d146a6e6e22cf

src/qt/res/icons/*

 src/qt/res/icons/add.png

 src/qt/res/icons/address-book.png

 src/qt/res/icons/clock1.png

 src/qt/res/icons/clock2.png

 src/qt/res/icons/clock3.png

 src/qt/res/icons/clock4.png

 src/qt/res/icons/clock5.png

 src/qt/res/icons/configure.png

 src/qt/res/icons/debugwindow.png

 src/qt/res/icons/edit.png

 src/qt/res/icons/editcopy.png

 src/qt/res/icons/editcopy.png

 src/qt/res/icons/editpaste.png

 src/qt/res/icons/export.png

 src/qt/res/icons/filesave.png

 src/qt/res/icons/history.png

 src/qt/res/icons/key.png

 src/qt/res/icons/lock_closed.png

 src/qt/res/icons/lock_open.png

 src/qt/res/icons/overview.png

 src/qt/res/icons/quit.png

 src/qt/res/icons/receive.png

 src/qt/res/icons/remove.png

 src/qt/res/icons/send.png

 src/qt/res/icons/synced.png

 src/qt/res/icons/transaction0.png

 src/qt/res/icons/transaction2.png

Icons replaced

 src/qt/res/icons/transaction_conflicted.png

 src/qt/res/icons/tx_inout.png

 src/qt/res/icons/tx_input.png

 src/qt/res/icons/tx_mined.png

 src/qt/res/icons/tx_output.png

Subsequently updated or changed?

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update Blue Bar FTC Logo to be aligned at bottom :: commit

Update Blue Bar FTC Logo to be algned at bottom on Command Line Options Panel

UI update - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/39c46ed18caa1d1aa55f491306974e775e229aae

src/qt/forms/helpmessagedialog.ui

-           <pixmap>:/images/about</pixmap>

+      <pixmap resource="../bitcoin.qrc">:/images/about</pixmap>

Example of Interface updaes

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Testing alternate splash screen pop-u :: commit

Testing alternate splash screen pop-up - Stand by / back-up new image for new version.

UI update - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/c0b860388655023260ea3d6b87f4bc395a4db0fe

src/qt/res/images/*

src/qt/res/images/splash.1.png

src/qt/res/images/splash.2.png

src/qt/res/images/splash.png

Backup new splash screen

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update splash screen to improve text layout :: commit

Layout changes Splash screen

UI update - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/8a9fc2a002cc1c07acc78f16c5669d418728d3e5

src/qt/splashscreen.cpp

 +    int paddingRight            = 298;
 +    int paddingTop              = 230;

Example layout change

updated splashscreen layout latest .cpp version :: commit

https://github.com/FeatherCoin/Feathercoin/commit/fdbf3f5882c3abc55227707a9e085884b1d61660

src/qt/splashscreen.cpp

  -    int paddingRight            = 298;
 +    int paddingRight            = 296;

Minor Layout tweak

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update configure.ac :: commit

Release should be false

https://github.com/FeatherCoin/Feathercoin/commit/1a9bf803f2a5e3afb270fabb43fbe39ed181f664

configure.ac

 -define(_CLIENT_VERSION_IS_RELEASE, true)

 +define(_CLIENT_VERSION_IS_RELEASE, false)

Code replaced. Only release engineer should set

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update multisignature and reports icon :: commit

Update icons

UI update - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/8a9fc2a002cc1c07acc78f16c5669d418728d3e5

src/qt/res/icons/*

 src/qt/res/icons/account-report.png

 src/qt/res/icons/multisig.png

Updated icons

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Correct whit spelling error :: commit

Correct whit spelling error on Shape shift in bitcoingui.cpp

UI update - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/7711a770a6e1d38369748699ee96148ff0008e51

src/qt/bitcoingui.cpp

-// Copyright (c) 2013-2015 The Feathercoin developers

+// Copyright (c) 2013-2016 The Feathercoin developers

Copyright needs updating

  -    shapeshiftAction->setStatusTip(tr("Exchange other coins whit your feathercoin on Shapeshift"));
 +    shapeshiftAction->setStatusTip(tr("Exchange other coins with your feathercoin on Shapeshift"));

Review change is in Translation files …

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update snapwidget.ui with a distinct background colour, :: commit

Update snapwidget.ui with a distinct background colour, so it can be seen against a light or Dark theme, Ui release options

UI update - as part of development of GUI refresh. Difficult rationalization of screen splitting, fixing bugs with background image code. GUI work was done through Qt creator.

https://github.com/FeatherCoin/Feathercoin/commit/4c8e60990f3a3b9c691ef3e9d8b4e7a361abeb90

src/qt/forms/snapwidget.ui

 -  <widget class="QPushButton" name="snapButton">

 +  <property name="autoFillBackground">

Example UI layout changes / tweaks. reviewed later?