[Dev] Documenting Feathercoin Specific Software settings - Part 16

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Jump to 0.9.3.3 :: commit

Commit review overview

There are more contributers to this development branch than expected, members have done more work. @Wellenreiter has taken on software control.

Interface changes and addition code added was not followed through to the tests, under normal Bitcoin release rules would have prevented a release. These were reviewed as experimental, or tested out side the Bitcoin code (which had been tested), so 0.9.3.x was released as experimental software. @AmDD volunteered to work on the tests, assisted by admin team.

The version change was accepted, but further updates were in pipeline, there had been unofficial releases had similar numbers which confused members, which meant a jump to 0.9.6.x was necessary to communicate clearly which is the “official release”.

https://github.com/FeatherCoin/Feathercoin/commit/279b53be74cd4b20fe49eaf80d939991264d0d9f

configure.ac

 -AC_PREREQ([2.60])

 +AC_PREREQ([2.68])

Code replaced, why?

 -define(_CLIENT_VERSION_BUILD, 2)

 +define(_CLIENT_VERSION_BUILD, 3)

Code replaced, builds version number

 -  AC_TRY_COMPILE([#ifdef _FORTIFY_SOURCE

+  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#ifdef _FORTIFY_SOURCE

Code replaced, why?

 -     extern "C" long unsigned int __fdelt_warn(long unsigned int);],[],
 -    [ fdelt_type="long unsigned int"],
 -    [ fdelt_type="long int"])

Code removed

 +     extern "C" long unsigned int __fdelt_warn(long unsigned int);]], [[]])],[ fdelt_type="long unsigned int"],[ fdelt_type="long int"])

Code replaced

  -AC_TRY_COMPILE([#include <sys/socket.h>],
  - [ int f = MSG_NOSIGNAL; ],
 - [ AC_MSG_RESULT(yes); AC_DEFINE(HAVE_MSG_NOSIGNAL, 1,[Define this symbol if you have MSG_NOSIGNAL]) ],
 - [ AC_MSG_RESULT(no)]
 -)

    +AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <sys/socket.h>]], [[ int f = MSG_NOSIGNAL; ]])],[ AC_MSG_RESULT(yes); AC_DEFINE(HAVE_MSG_NOSIGNAL, 1,[Define this symbol if you have MSG_NOSIGNAL]) ],[ AC_MSG_RESULT(no)
 +])

Changed compile interface - why? is this necessary?

 -AC_TRY_LINK([

 +AC_LINK_IFELSE([AC_LANG_PROGRAM([[

Code replaced, Interface change?

 -  ],
 -  [boost_sleep=yes; BOOST_LIBS="$BOOST_LIBS $BOOST_CHRONO_LIB";
 -     AC_DEFINE(HAVE_WORKING_BOOST_SLEEP_FOR, 1, [Define this symbol if boost sleep_for works])],
 -  [boost_sleep=no])

 +  ]])],[boost_sleep=yes; BOOST_LIBS="$BOOST_LIBS $BOOST_CHRONO_LIB";
+     AC_DEFINE(HAVE_WORKING_BOOST_SLEEP_FOR, 1, [Define this symbol if boost sleep_for works])],[boost_sleep=no])

Code replaced

 -AC_TRY_LINK([

 +AC_LINK_IFELSE([AC_LANG_PROGRAM([[

Code replaced

  -  ],
  -  [boost_sleep=yes; AC_DEFINE(HAVE_WORKING_BOOST_SLEEP, 1, [Define this symbol if boost sleep works])], 

  +  ]])],[boost_sleep=yes; AC_DEFINE(HAVE_WORKING_BOOST_SLEEP, 1, [Define this symbol if boost sleep works])],[boost_sleep=no])

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update configure.ac :: commit

Commit review overview

The current version has not been passed for release.

https://github.com/FeatherCoin/Feathercoin/commit/9403a9e7792a491facda3f4c86548c13e2f642bf

configure.ac

-define(_CLIENT_VERSION_IS_RELEASE, true)
+define(_CLIENT_VERSION_IS_RELEASE, false)

Code replaced

Update configure.ac :: Commit

https://github.com/FeatherCoin/Feathercoin/commit/f2831c085b9db3c76200ec45392fdf035ff93b81

configure.ac

Release change regressed, changed later?

 -define(_CLIENT_VERSION_IS_RELEASE, false)
 +define(_CLIENT_VERSION_IS_RELEASE, true)

Update configure.ac :: Commit

https://github.com/FeatherCoin/Feathercoin/commit/1afcd2bcd3b3c98b9d4d2e2c1425629852a1346a

configure.ac

-define(_CLIENT_VERSION_IS_RELEASE, true)
+define(_CLIENT_VERSION_IS_RELEASE, false)

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update README.md :: commit

https://github.com/FeatherCoin/Feathercoin/commit/ecd6a92e51ec60ecb2e02dfd4bef5fc7b48db350

README.md

 +Status 0.9.3.2
 +--------------
 +development

Code added

  +Translators should also subscribe to the [mailing list](https://groups.google.com/forum/#!forum/bitcoin-translators).

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Version number update :: commit

Implement change control.

https://github.com/FeatherCoin/Feathercoin/commit/bdd4e89264e924f321eb0b0fee543669da928deb

configure.ac

 -define(_CLIENT_VERSION_REVISION, 3)
 -define(_CLIENT_VERSION_BUILD, 3)


 +define(_CLIENT_VERSION_REVISION, 6)
 +define(_CLIENT_VERSION_BUILD, 0)

Code updated. Distinct version / testing.

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Version number update :: commit

Updated gitignore, so files created by autoconf and configure are ignored. Release review and documentation procedure.

https://github.com/FeatherCoin/Feathercoin/commit/bdd4e89264e924f321eb0b0fee543669da928deb

.gitignore

 +#ignore binaries
 +# ignore files created by autoconf and conf

 +Makefile.in
 +share/qt/Info.plist
 +share/setup.nsi
 +src/Makefile.in
 +src/bitcoin-config.h
 +src/qt/Makefile.in
 +src/qt/test/Makefile.in
 +src/test/Makefile.in

 +#ignore files created during make

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Disables coinnector and shapeshift plugin :: commit

Disables coinnector and shapeshift plugin : Vanity bounty projects disabled as not reconfigured by Shapeshift after they were “hacked” or something. Have indicated FTC would be back on soon (2016) review

Release review and documentation procedure.

https://github.com/FeatherCoin/Feathercoin/commit/50e7ff09941f23d62426bf6a4c4b78cc7e5d4815

Makefile.in

build file - should be in git ignore, removed

share/setup.nsi

build file - should be in git ignore, removed

share/qt/Info.plist

build file - should be in git ignore, removed

src/bitcoin-config.h

Removed ??

src/qt/Makefile.in

build file - should be in git ignore, removed

src/qt/test/Makefile.in

build file - should be in git ignore, removed

src/test/Makefile.in

build file - should be in git ignore, removed

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Disables coinnector and shapeshift plugin :: commit

Disables coinnector and shapeshift plugin : Vanity bounty projects disabled as not reconfigured by Shapeshift after they were “hacked” or something. Have indicated FTC would be back on soon (2016) review

Release review and documentation procedure.

https://github.com/FeatherCoin/Feathercoin/commit/50e7ff09941f23d62426bf6a4c4b78cc7e5d4815

configure.ac

 -AC_PREREQ([2.68])

 +AC_PREREQ([2.69])

Code replaced

src/qt/bitcoingui.cpp

 +//#include "shiftdialog.h"
 +//#include "coinnectordialog.h"

Code commented out

 +    /*
 +     * Shapeshift and coinnector don't work for feathercoin anymore
 +     * therefore remove the menu entries
 +     *

Supposedly, temporary removal of massive amount of work and expense.

 +//        connect(shapeshiftAction, SIGNAL(triggered()), this, SLOT(openShapeshiftClicked()));
 +//        connect(coinnectorAction, SIGNAL(triggered()), this, SLOT(openCoinnectorClicked()));

Supposedly, temporary removal of massive amount of work and expense.

 +     //   plugins->addAction(shapeshiftAction);
 +     //   plugins->addAction(coinnectorAction);

Supposedly, temporary removal of massive amount of work and expense.

 +/* 
 + * Coinnector and shapeshift disabled
 + * 
 + *

Supposedly, temporary disabling of massive amount of work and expense by FTC.

src/qt/bitcoingui.h

 +//   QAction *shapeshiftAction;

Code commented out

 +//  QAction *coinnectorAction;
 + //   void openShapeshiftClicked();

 +//    void openCoinnectorClicked();

Supposedly, temporary disabling of massive amount of work and expense by FTC to include.

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Updated ReadMe File :: commit

First set of updates to Readme / documentation / graphics and MAC build

https://github.com/FeatherCoin/Feathercoin/commit/1733de9ee5649d7b13e2c5acbbdf05d2e8b046d9

contrib/macdeploy/README.md

 +When finished, it will produce `Feathercoin-Qt.dmg`.

Code replaced Feathercoin name

changed ReadMe File again :: commit

https://github.com/FeatherCoin/Feathercoin/commit/226071a4e7cb0b820d0ac132bbdc51422a35baf5

contrib/macdeploy/README.md

 ++When finished, it will produce "Feathercoin-Qt.dmg".

Code updated Feathercoin name

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Changed DMG installer Background :: commit

First set of updates to Readme / documentation / graphics and MAC build

https://github.com/FeatherCoin/Feathercoin/commit/b11bc8b94da8245a5bb80b28b84b7994d78b59a8

contrib/macdeploy/*

  contrib/macdeploy/background.png

  contrib/macdeploy/background.psd

Image files added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Removed bitcoin-qt related config, :: commit

Removed bitcoin-qt related config, added feathercoin-qt, needed for OSX dmg build

Set of updates to Readme / documentation / graphics and MAC build

https://github.com/FeatherCoin/Feathercoin/commit/b7e10f78bc1285aea6ad6eca378ac63976e21773

contrib/macdeploy/fancy.plist

 +	<key>Feathercoin-Qt.app</key>

Code replaced name change to Feathercoin

 + "disk" : "Feathercoin-Qt",

Code replaced name change to Feathercoin

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

More small fixes for Mac DMG creation :: commit

More small fixes for Mac DMG creation, MAC build

Set of updates to Readme / documentation / graphics and MAC build

https://github.com/FeatherCoin/Feathercoin/commit/31530d176c0ccd770d22ee869fb7bbb513f02cc5

share/qt/Info.plist.in

 +  <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@, Copyright © 2009-@COPYRIGHT_YEAR@ The Feathercoin Core developers</string>

Code replaced name to Feathercoin

 +  <string>Feathercoin-Qt</string>

 +  <string>feathercoin</string>

Code replaced name

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update compile documentation /doc/ readme.md :: commit

Update compile documentation /doc/ readme.md update - update apropriate version number 0.9.6

https://github.com/FeatherCoin/Feathercoin/commit/274fa8b1c4a2275b514a9a3c4266b952fb1bdf35

doc/README.md

+Feathercoin 0.9.6

Code replaced, some additional MD spaces added for layout.

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed boost c++11 build error :: commit

Fixed boost c++11 build error - ambiguous overload in chainparams.cpp

Fixes this error:
chainparams.cpp: In constructor ‘CMainParams::CMainParams()’:
chainparams.cpp:85:52: error: ambiguous overload for ‘operator=’ (operand types are ‘std::vector<unsigned char>’ and ‘boost::assign_detail::generic_list<int>’)
base58Prefixes[PUBKEY_ADDRESS] = list_of(14); // FeatherCoin addresses start with F
^
In file included from /usr/include/c++/6.2.1/vector:69:0,
from serialize.h:21,
from bignum.h:9,
from chainparams.h:9,
from chainparams.cpp:6:
/usr/include/c++/6.2.1/bits/vector.tcc:167:5: note: candidate: std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const std::vector<_Tp, _Alloc>&) [with _Tp = unsigned char; _Alloc = std::allocator<unsigned char>]
vector<_Tp, _Alloc>::

https://github.com/FeatherCoin/Feathercoin/commit/1791804d77a71e9cc1060b2ce0210dc9407f4a6e

src/chainparams.cpp

 -        base58Prefixes[PUBKEY_ADDRESS] = list_of(14); // FeatherCoin addresses start with F
 -        base58Prefixes[SCRIPT_ADDRESS_OLD] = list_of(5);
 -        base58Prefixes[SCRIPT_ADDRESS] = list_of(5);
 -        base58Prefixes[SECRET_KEY] =     list_of(142);// 14+128
 -        base58Prefixes[EXT_PUBLIC_KEY] = list_of(0x04)(0x88)(0xBC)(0x26);
 -        base58Prefixes[EXT_SECRET_KEY] = list_of(0x04)(0x88)(0xDA)(0xEE);

Code removed

     //how to do feathercoin ?
 +        base58Prefixes[PUBKEY_ADDRESS] = std::vector<unsigned char>(1,14); // FeatherCoin addresses start with F
 +        base58Prefixes[SCRIPT_ADDRESS_OLD] = std::vector<unsigned char>(1,5);
   //  base58Prefixes[SCRIPT_ADDRESS] = list_of(96);
 +        base58Prefixes[SCRIPT_ADDRESS] = std::vector<unsigned char>(1,5);
 +        base58Prefixes[SECRET_KEY] =     std::vector<unsigned char>(1,142);// 14+128
 +        base58Prefixes[EXT_PUBLIC_KEY] = boost::assign::list_of(0x04)(0x88)(0xBC)(0x26).convert_to_container<std::vector<unsigned char> >();
 +        base58Prefixes[EXT_SECRET_KEY] = boost::assign::list_of(0x04)(0x88)(0xDA)(0xEE).convert_to_container<std::vector<unsigned char> >();

Code (was) replaced

 -        base58Prefixes[PUBKEY_ADDRESS] = list_of(65);
 +        base58Prefixes[PUBKEY_ADDRESS] = std::vector<unsigned char>(1,65);

 -        base58Prefixes[SCRIPT_ADDRESS] = list_of(196);
 +        base58Prefixes[SCRIPT_ADDRESS] = std::vector<unsigned char>(1,196);

 -        base58Prefixes[SECRET_KEY]     = list_of(193);//65+128
 +        base58Prefixes[SECRET_KEY]     = std::vector<unsigned char>(1,193);//65+128

 -        base58Prefixes[EXT_PUBLIC_KEY] = list_of(0x04)(0x35)(0x87)(0xCF);
 +        base58Prefixes[EXT_PUBLIC_KEY] = boost::assign::list_of(0x04)(0x35)(0x87)(0xCF).convert_to_container<std::vector<unsigned char> >();

 -        base58Prefixes[EXT_SECRET_KEY] = list_of(0x04)(0x35)(0x83)(0x94);
 +        base58Prefixes[EXT_SECRET_KEY] = boost::assign::list_of(0x04)(0x35)(0x83)(0x94).convert_to_container<std::vector<unsigned char> >();

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update README.md :: commit

https://github.com/FeatherCoin/Feathercoin/commit/3d895ca2d79b4494f53afa37a02890cda65289dd

https://github.com/FeatherCoin/Feathercoin/commit/81d7655ee312e60efee398950d871f8ce19a4b81

README.md

 +release candidate

Minor text update

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed Issue #125; set staarting block to 556535 :: commit

#125; 0.9.3.2 - Test result – Help / SX Stealth search
If you search from 1 or a low number a message is shown :
Beginning Height must be greater than 556535.
A simple enhancement would be to fill 556535 into the start field …

https://github.com/FeatherCoin/Feathercoin/commit/0275468c8c26799f84afbddeb5cbeed3c1ebfbfc

src/qt/forms/debugdialog.ui

 +   <property name="text">
 +    <string>556535</string>
 +   </property>

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fix a bug in multi-sign page :: commit

fix a bug in multi-sign page
fix a bug in multi-sign page, It is on max os. (MAC OS)

https://github.com/FeatherCoin/Feathercoin/commit/01b65443a91922fa91758a344c746c4f7594d353

src/qt/multisigdialog.cpp

 -    ui->btnCreateAddr->setIcon(QIcon());

Code removed

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed Issue #126 :: commit

A search for stealth coins failed with crash.
How to replicate : help - SX Stealth search, set low 556536, set high 10000000
Start Feathercoin on the “Command Line”
message on command line start up :
StealthSecret(): Q EC_POINT_bn2point failed
Segmentation fault (core dumped)

https://github.com/FeatherCoin/Feathercoin/commit/7b775f3c8bb4532d8cd60de5cc2b5d53673f2f3f

src/qt/utilitydialog.cpp

 -    int i;
 -    for(i=nFromHeight2;i>=nFromHeight;i--)

+    while (pindex->nHeight >= nFromHeight)

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed Issue #122 :: commit

0.9.3.2 - Test SX stealth coin Search in Help
Enhance SX search by defaulting “end search field” to the latest block height number

https://github.com/FeatherCoin/Feathercoin/commit/52103ce00a6040008c461d2ffa6ea115fb80590e

src/qt/utilitydialog.cpp

 +    CBlockIndex *pindex = chainActive.Genesis();

 ui->setupUi(this);

+    pindex = mapBlockIndex[chainActive.Tip()->GetBlockHash()];
+    ui->addrEdit2->insert(QString("%1").arg(pindex->nHeight));
+

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed Issue #123 :: commit

Help - SX Search :
When you search for a stealth address, the information given seems incorrect.
After a wait (while the search happens, button goes blue) a message pops up
“Scan stealth transactions on Blockchain,Yes!!!”
No Stealth addresses were found for the wallet . Click OK and it exits :
Text needs updating : scan complete SX coins found for wallet or not

https://github.com/FeatherCoin/Feathercoin/commit/f6cbba726e8f70a9aed2e738f5a6f13e941ebd91

src/qt/utilitydialog.cpp

 -		        LogPrintf("Find a stealth transaction %s :reason %s  .\n",tx.GetHash().ToString(),reason);

 +		        LogPrintf("Found stealth transaction %s :reason %s  .\n",tx.GetHash().ToString(),reason);

Code replaced

 -    QMessageBox::information(NULL, tr("Wallet Message"), tr("Scan stealth transactions on blockchain,Yes!!!"), QMessageBox::Yes , QMessageBox::Yes);

 +    QMessageBox::information(NULL, tr("Wallet Message"), tr("%1 stealth transactions found on blockchain.").arg(numberSxTransaction), QMessageBox::Yes , QMessageBox::Yes);

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed boost c++11 build error - ambiguous overload in chainparams.cpp :: commit

Fixes this error:
chainparams.cpp: In constructor ‘CMainParams::CMainParams()’:
chainparams.cpp:85:52: error: ambiguous overload for ‘operator=’ (operand types are ‘std::vector<unsigned char>’ and ‘boost::assign_detail::generic_list<int>’)
base58Prefixes[PUBKEY_ADDRESS] = list_of(14); // FeatherCoin addresses start with F
^
In file included from /usr/include/c++/6.2.1/vector:69:0,
from serialize.h:21,
from bignum.h:9,
from chainparams.h:9,
from chainparams.cpp:6:
/usr/include/c++/6.2.1/bits/vector.tcc:167:5: note: candidate: std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const std::vector<_Tp, _Alloc>&) [with _Tp = unsigned char; _Alloc = std::allocator<unsigned char>]
vector<_Tp, _Alloc>::

https://github.com/FeatherCoin/Feathercoin/commit/c29adf99bbfe054608c37317294ceec4aab6720a

src/qt/transactionview.cpp

 -        QString program="./bitmessagemain ";

+	#if defined(Q_OS_LINUX)
+	  QString program="pybitmessage";
+	#else
+	  QString program="./bitmessagemain";
+	#endif

Code replaced