Forum Home
    • Register
    • Login
    • Search
    • Recent
    • Tags
    • Popular

    [Dev] Feathercoin 0.9.6.2 * Maintenance fix, build & upgrade issues notes.

    Technical Development
    8
    153
    75111
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • wrapper
      wrapper Moderators last edited by wrapper

      net.cpp Line 316

      if (!ConnectSocket(addrConnect, hSocket))
          {
          if (fDebug)    
               LogPrintf("GetMyExternalIP() : connection to %s failed", addrConnect.ToString());
          return true;
          }
      

      Debug selection code added, removed from return error.

      init.cpp Line 112

      if (fDebug)
         LogPrintf("Shutdown : In progress...\n");
      

      init.cpp Line 152

      if (fDebug)
          LogPrintf("Shutdown : done\n");
      

      Code added

      net.cpp Line 240

      if (fDebug)
          LogPrintf("AddLocal(%s,%i)\n", addr.ToString(), nScore);
      

      net.cpp Line 1732

                  {
                      if (fDebug)
                         LogPrintf("IPv4 %s: %s\n", ifa->ifa_name, addr.ToString());
      
      
                  }
      

      net.cpp Line 429

          if (fDebug)
               LogPrintf("GetMyExternalIP() returned %s\n", addrLocalHost.ToStringIP());
          AddLocal(addrLocalHost, LOCAL_HTTP);
      

      netbase.cpp Line 366

                 if (fDebug)
                      LogPrintf("select() for %s failed: %s\n", addrConnect.ToString(), NetworkErrorString(WSAGetLastError()));
      

      netbase.cpp Line 385

                  if (fDebug)
                      LogPrintf("connect() to %s failed after select(): %s\n", addrConnect.ToString(), NetworkErrorString(nRet));
      

      init.cpp Line 1062

          if (fDebug)
          {
               LogPrintf("%s", strErrors.str());
               LogPrintf(" wallet      %15dms\n", GetTimeMillis() - nStart);
          }
      

      main.cpp Line 4722

          if (fDebug)
              LogPrintf("Receive checkpoint,hashCheckpoint=%s\n.",checkpoint.hashCheckpoint.ToString().c_str());
      
          if (checkpoint.ProcessSyncCheckpoint(pfrom))
          {
                  if fDebug)
                     LogPrintf("checkpoint.ProcessSyncCheckpoint(pfrom)=true, hashCheckpoint=%s\n.",checkpoint.hashCheckpoint.ToString().c_str());
      

      Code Added

      1 Reply Last reply Reply Quote 0
      • wrapper
        wrapper Moderators last edited by wrapper

        net.cpp - Line 1771

         if (fDebug)
            LogPrintf("StopNode()\n");
        

        net.cpp - Line 1799

           if (fDebug)
               LogPrintf("DNS seeding disabled\n");
        

        Util.h

        Various thread start end messages

           { 
                 if (fDebug)
            /        LogPrintf("%s thread start\n", name);
                 func();
                 if (fDebug)
                      LogPrintf("%s thread exit\n", name);
             }
             catch (boost::thread_interrupted)
             {
                  if (fDebug)
                        LogPrintf("%s thread interrupt\n", name);
        

        Code added

        /src/qt/bitcoin.cpp

        if (fDebug)
            LogPrintf("Requesting initialize\n");
        
        
        if (f Debug)
           LogPrintf("Requesting shutdown\n");
        
        if (fDebug)
           LogPrintf("Stopping thread\n");
        emit stopThread();
        coreThread->wait();
        if (fDebug)
            LogPrintf("Stopped thread\n");
        

        Code added

             {
                 if (fDebug)
                     LogPrintf("Running Shutdown in thread\n");
                 threadGroup.interrupt_all();
                 threadGroup.join_all();
                 Shutdown();
                 if (fDebug)
                     LogPrintf("Shutdown finished\n");
        

        Code added

            if (fDebug)
                LogPrintf("Running AppInit2 in thread\n");
        

        Code added

        if (fDebug)
            LogPrintf("init message: %s\n", message);
        

        Code added

        if (fDebug)
            LogPrint("qt", "GUI: %s\n", msg);
        

        Code added

        if (fDebug)
             LogPrint("qt", "GUI: %s\n", qPrintable(msg));
        

        Code added

        1 Reply Last reply Reply Quote 0
        • wrapper
          wrapper Moderators last edited by wrapper

          Remaining Messages

          2017-08-12 18:01:39 Receive checkpoint,hashCheckpoint=0000000000000000000000000000000000000000000000000000000000000000
          .ERROR: CSyncCheckpoint::CheckSignature() : verify signature failed
          2017-08-12 18:02:05 UPNP_DeletePortMapping() returned : 0

          net.cpp

                  if (fDebug)
                      LogPrintf("UPNP_DeletePortMapping() returned : %d\n", r);
          

          Code added

                  if(r != UPNPCOMMAND_SUCCESS)
                      if (fDebug)
                           LogPrintf("UPnP: GetExternalIPAddress() returned %d\n", r);
                  else
          

          Code added

                     else
                          if (fDebug)
                              LogPrintf("UPnP: GetExternalIPAddress failed.\n");
          

          Code added

                      if(r!=UPNPCOMMAND_SUCCESS)
                          if (fDebug)
                              LogPrintf("AddPortMapping(%s, %s, %s) failed with code %d (%s)\n",
                              port, port, lanaddr, r, strupnperror(r));
          

          Code added

          checkpointsync.cpp

          if (!key.SetPubKey(ParseHex(strMasterPubKey)))
              {
              if (fDebug)
                  LogPrintf("CSyncCheckpoint::CheckSignature() : SetPubKey failed");
              return true;
              }
          if (!key.Verify(Hash(vchMsg.begin(), vchMsg.end()), vchSig))
              {
              if (fDebug)
                  LogPrintf("CSyncCheckpoint::CheckSignature() : verify signature failed");
              return true;
              }
          

          Code added

          1 Reply Last reply Reply Quote 1
          • Wellenreiter
            Wellenreiter Moderators last edited by

            I’d keep the last one, as ACP checkpoint checksignature failed is relative important

            Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
            Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

            1 Reply Last reply Reply Quote 1
            • wrapper
              wrapper Moderators last edited by wrapper

              I’ve been through and added more, if (fDebug) (as opposed to just commenting them out) .

              Most of the debug messages are still there, you just have to run -debug to see them. The checkpoint “error” did not seem to be a “Fault”, just a none complaint checkpoint.

              1 Reply Last reply Reply Quote 1
              • wrapper
                wrapper Moderators last edited by wrapper

                [FAQ] What is the difference between LogPrint() and LogPrintf() in the Feathercoin/Bitcoin source code?

                Under normal conditions the LogPrintf() should only be used to report an unusual error, otherwise it is used during development to confirm an action and commented out for production versions.

                Writing unnecessary messages to debug slows the system and takes up disk space. Whilst the debug can be shrunk, this relies on additional parameters being passed or set up at install time.

                LogPrintf() statements log the output into debug.log file. LogPrint() statements only out put to the log file if -debug is set.

                1 Reply Last reply Reply Quote 0
                • wrapper
                  wrapper Moderators last edited by

                  main.h

                   static const unsigned int DEFAULT_MAX_ORPHAN_TRANSACTIONS = 100;
                    /** Default for -maxorphanblocks, maximum number of orphan blocks kept in memory */
                   -static const unsigned int DEFAULT_MAX_ORPHAN_BLOCKS = 750;
                  
                   +static const unsigned int DEFAULT_MAX_ORPHAN_BLOCKS = 7500;
                  
                    /** The maximum size of a blk?????.dat file (since 0.8) */
                  

                  Increased Max orphans default to 7500.

                  Wellenreiter 1 Reply Last reply Reply Quote 0
                  • Wellenreiter
                    Wellenreiter Moderators @wrapper last edited by

                    @wrapper

                    too high. I’d try 1500.

                    There is a reason to limit the max number of orphan blocks

                    Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
                    Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

                    wrapper 1 Reply Last reply Reply Quote 0
                    • wrapper
                      wrapper Moderators @Wellenreiter last edited by wrapper

                      @Wellenreiter said in [Dev] Feathercoin 0.9.6.2 * Maintenance fix, build & upgrade issues notes.:

                      @wrapper

                      too high. I’d try 1500.

                      There is a reason to limit the max number of orphan blocks

                      I’ve tested it at 10,000 and that is (7500) what Dogecoin raised it to. There is no point it being lower, it was set too low.

                      Wellenreiter 1 Reply Last reply Reply Quote 0
                      • Wellenreiter
                        Wellenreiter Moderators @wrapper last edited by Wellenreiter

                        @wrapper it’s a security measure against (D)DOS attacks to the BC, so it will work even when set to 10000000, but may stall the BC, if someone injects a high number of orphans. I’m not sure how many orphans an attacker could create, but…

                        Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
                        Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

                        1 Reply Last reply Reply Quote 0
                        • wrapper
                          wrapper Moderators last edited by

                          From the sync tests, we know there are already > 6000 ORHAN BLOCKS chains in the Blockchain already…

                          1 Reply Last reply Reply Quote 0
                          • wrapper
                            wrapper Moderators last edited by wrapper

                            https://github.com/FeatherCoin/Feathercoin/pull/216

                            Debug.log io review - Resultant fixes / improvements:

                            A large number of debug messages were only useful in development and have been commented out.

                            A further large number of messages only indicate information in an error condition and have will now only write out if -debug is set.

                            A small number of error messages are alerted during sync, because they are on an orphan chain, that is correct (to have the error). Further errors may need investigating so they were changed to write on -debug.

                            Because the max ORPHAN BLOCKS in a chain exceeds the current temporary memory pool during sync, this caused stalling whilst the memory was reloaded. The memory can be increased with a switch -maxorphanblocks=10000 - This has been increased from 750 to 7500, as per Dogecoin fix, is being tested for sufficiency / memory issues.

                            A number of LogPrintf() messages were reviewed and considered useful error messages to write to Debug.log that may help support in unusual circumstances. These were left unchainged.

                            UTF-8 translations were backported from 0.11.2

                            The Feathercoin client is now starting and stopping without creating a debug.log. When Debug is initiated the information is more succinct and relevant. The synchronization time is very significantly improved.

                            1 Reply Last reply Reply Quote 0
                            • wrapper
                              wrapper Moderators last edited by wrapper

                              Remaining Messages no Debug:

                              2017-08-13 13:48:40 partner xxx.xxx.xxx.xxx:9336 using obsolete version 60002; disconnecting
                              2017-08-13 13:48:40 ProcessMessage(version, 102 bytes) FAILED
                              2017-08-13 14:00:00 ERROR: CAlert::CheckSignature() : verify signature failed
                              2017-08-13 14:00:51 ERROR: CheckBlockHeader() : block with timestamp before last checkpoint
                              2017-08-13 14:00:51 ERROR: ProcessBlock() : CheckBlock FAILED
                              2017-08-13 14:00:51 ERROR: CheckBlockHeader() : block with timestamp before last checkpoint
                              2017-08-13 14:00:51 ERROR: ProcessBlock() : CheckBlock FAILED

                              Large block same message then :

                              2017-08-13 14:08:52 socket recv error Connection reset by peer (104)

                              ~Block 1145437

                              src/main.cpp - Line 2835
                              2017-08-13 14:00:51 ERROR: CheckBlockHeader() : block with timestamp before last checkpoint

                                   if (deltaTime < 0)
                                     {
                                         return state.DoS(100, error("CheckBlockHeader() : block with timestamp before last checkpoint"),
                                       REJECT_CHECKPOINT, "time-too-old");
                              

                              These are old rejected blocks, I assume, so not required on sync.

                              main.cpp - Updated code

                                   {
                                       if (fDebug)
                                            LogPrintf("CheckBlockHeader() : block with timestamp before last checkpoint");
                                       return state.DoS(100, NULL,
                                                        REJECT_CHECKPOINT, "time-too-old");
                                   }
                              

                              Code added

                              main.cpp Line 3199

                              if (!CheckBlock(*pblock, state, INT_MAX)) 
                              	  return error("ProcessBlock() : CheckBlock FAILED");
                              

                              Updated to :

                              if (!CheckBlock(*pblock, state, INT_MAX)) 
                                        if (fDebug)
                                            LogPrintf("ProcessBlock() : CheckBlock FAILED");
                              	  return true ;
                              

                              netbase.cpp

                              Update with Bitcoin bug fix to correct (104) error

                              https://github.com/bitcoin/bitcoin/issues/4552
                              https://github.com/bitcoin/bitcoin/commit/109849e204f91d8b04b0e57da87e45b461096b50

                              1 Reply Last reply Reply Quote 0
                              • wrapper
                                wrapper Moderators last edited by wrapper

                                Full sync from scratch Test, 0.9.6.2 in progress

                                So far : 2.5 years in 13 hours : 5 hrs P/Day. - estimate 20 hrs full sync time (~4pm).

                                Remaining Debug messages :

                                2017-08-13 18:12:10 socket recv error Connection reset by peer (104)
                                2017-08-13 18:25:03 socket recv error Connection timed out (110)

                                Recommendation :

                                The Debug.log testing has shown that a number of operation, which were envisioned as errors initially, have occurred in the blockchain. This has meant that certain settings, loop levels or error messages are repeated during re-syncronisation of the blockchain.

                                Where’as 0.11.2 version already contain some speed ups that effect Bitcoin, (secp256k1) the FTC block sync is considerably reduced, but at ~22 hrs (estimate), would still seem long.

                                ToDo.

                                Set up a script and chron job to pole feathercoin during a resync and write Blocknumber every minute. This will 1200 data points to identify any problem block chains. These may indicate further settings that can be tweaked.

                                 feathercoind getinfo >> StallTest.txt
                                

                                Preliminary test show synchronization is running pretty consistently at :

                                BlocksPerHour
                                39750
                                BlocksPerMinute
                                662

                                Full sync took 29 Hours, with no special settings and 4 outputs to debug, about lost connections…

                                BlockSycTest

                                Get Block count was often delayed

                                BlockSycTest

                                Blocks per minute

                                BlockSycTest

                                Testable

                                -dbcache to a value around 4000

                                8 connections limitation

                                Give Higher CPU Priority to Bitcoin-Qt Process
                                The above approach of blockchain import should be faster than syncing the whole blockchain block by block. Give the process higher CPU priority might further help speeding up the blockchain import especially you have more CPU cycle at your disposal. If you’re using Mac OS X, and assuming the Process ID (PID) of Bitcoin-Qt is 2202, use the following command to give Bitcoin-Qt process hight CPU priority:

                                sudo renice -20 -p 2202
                                

                                *-20 is the nice value a value between -20 and +19. The lower the nice value, the higher priority the process gets.

                                1 Reply Last reply Reply Quote 0
                                • wrapper
                                  wrapper Moderators last edited by wrapper

                                  Results of Sync Speed Tests

                                  Found very interesting Result from Sync speed Tests :::::

                                  The sync speed dropped from ~710 Blocks per minute to ~670 Blocks per minute

                                  After the synchronsiation passed the Hard Fork for : One minute Blocks, Neoscrypt and eHRC additional calculations.

                                  This is actually impressive as we are processing 2.5 times the amount of blocks and re-targeting every block! It indicates that Neoscrypt is efficient. Thanks @Ghostlander.

                                  Although it might also be effected by other factors, such as the increasing number of transactions, it mean that it would be worthwhile to do the Neoscrypt update :

                                  https://github.com/ghostlander/Phoenixcoin/commit/ddbdbf6cbff4ca52f87268f28c60d588bf843344

                                  I suggest we test that in 0.9.6.2 as the best version / (none alpha) we have at the moment.

                                  1 Reply Last reply Reply Quote 0
                                  • wrapper
                                    wrapper Moderators last edited by

                                    Results of dbcache test

                                    Comparison shows a slight improvement with dbcache set to 3000, particularly as glitch in initial test associated with dropout, or network effect.

                                    It may be worth while to increase default to 1000 from 300, minor downside of disk space / memory.

                                    dbcache set to 3000

                                    1 Reply Last reply Reply Quote 0
                                    • wrapper
                                      wrapper Moderators last edited by wrapper

                                      Test changing max outbound connections

                                      Test upping default from lowly 8 to more reasonable 30

                                      net.cpp

                                      static const int MAX_OUTBOUND_CONNECTIONS = 30;

                                      1st test : slower only maintained 3 connections.

                                      Up from 125 to 200:
                                      int nMaxConnections = 200;

                                      Wellenreiter 1 Reply Last reply Reply Quote 0
                                      • Wellenreiter
                                        Wellenreiter Moderators @wrapper last edited by wrapper

                                        @wrapper

                                        It takes some time to build up more connections, I usually have 8 connections and after one or more hours it goes up to 10-12.
                                        The explorer hosts maintain given or taken ~ 100 peers after some days being online

                                        Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
                                        Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

                                        1 Reply Last reply Reply Quote 1
                                        • wrapper
                                          wrapper Moderators last edited by wrapper

                                          LTC also recommends 1000MB max dbcache. Testing increase min from 4 to 10.

                                          src/txdb.h

                                           // -dbcache default (MiB)
                                          static const int64_t nDefaultDbCache = 100;
                                          // max. -dbcache in (MiB)
                                          static const int64_t nMaxDbCache = sizeof(void*) > 4 ? 4096 : 1024;
                                           // min. -dbcache in (MiB)
                                          static const int64_t nMinDbCache = 4;
                                          
                                          1 Reply Last reply Reply Quote 0
                                          • wrapper
                                            wrapper Moderators last edited by wrapper

                                            stealth.cpp - 0.9.6.2

                                            std::string CStealthAddress::Encoded() const
                                            {
                                            // https://wiki.unsystem.net/index.php/DarkWallet/Stealth#Address_format
                                            // [version] [options] [scan_key] [N] ... [Nsigs] [prefix_length] ...
                                            
                                            data_chunk raw;
                                            raw.push_back(stealth_version_byte);
                                            
                                            raw.push_back(options);
                                            
                                            raw.insert(raw.end(), scan_pubkey.begin(), scan_pubkey.end());
                                            raw.push_back(1); // number of spend pubkeys
                                            raw.insert(raw.end(), spend_pubkey.begin(), spend_pubkey.end());
                                            raw.push_back(0); // number of signatures
                                            raw.push_back(0); // ?
                                            
                                            AppendChecksum(raw);
                                            
                                            return EncodeBase58(raw);
                                            };
                                            

                                            In this shadow coding why is raw.push_back(0); // ? called twice?

                                            Wellenreiter 1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post