Forum Home
    • Register
    • Login
    • Search
    • Recent
    • Tags
    • Popular

    [Dev] Feathercoin 0.9.6.2 * Maintenance fix, build & upgrade issues notes.

    Technical Development
    8
    153
    74618
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • AcidD
      AcidD Moderators last edited by

      Not sure where to log this, maybe github.

      Somewhere in the code, it still says the Copyright is 2013-2016

      You can see this in the file properties on windows when you build Feathercoin-QT v0.9.6

      Feathercoin-QT v0.9.6 Properties

      This should be changed to 2017…to reflect the new year :-)

      • FTC Block Explorer + API @ https://fsight.chain.tips
      • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
      • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
      • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

      1 Reply Last reply Reply Quote 0
      • Wellenreiter
        Wellenreiter Moderators last edited by

        Mhh, I thought I had changed the end year to 2017

        best is to log an issue on github, so we can track and solve it, even if you solve it yourself ;)

        Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
        Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

        AcidD 1 Reply Last reply Reply Quote 0
        • AcidD
          AcidD Moderators last edited by

          I’ll see what happens with these:
          https://github.com/FeatherCoin/Feathercoin/search?utf8=✓&q=2016 :-)

          • FTC Block Explorer + API @ https://fsight.chain.tips
          • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
          • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
          • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

          1 Reply Last reply Reply Quote 0
          • AcidD
            AcidD Moderators @Wellenreiter last edited by

            @Wellenreiter said in [Dev] Feathercoin 0.9.7-dev * Bug fix & issues notes for 0.11:

            Mhh, I thought I had changed the end year to 2017

            best is to log an issue on github, so we can track and solve it, even if you solve it yourself ;)

            Github issue created. When I get some time I’m gonna go and change it, I can test with my windows build environment.

            will send my PR to 0.9.7-dev

            • FTC Block Explorer + API @ https://fsight.chain.tips
            • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
            • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
            • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

            1 Reply Last reply Reply Quote 0
            • lizhi
              lizhi last edited by

              QT Copyright is in src\qt\res\feathercoin-qt-res.rc

              1 Reply Last reply Reply Quote 1
              • lizhi
                lizhi last edited by

                src\clientversion.h

                Wellenreiter 1 Reply Last reply Reply Quote 1
                • Wellenreiter
                  Wellenreiter Moderators @lizhi last edited by

                  @lizhi said in [Dev] Feathercoin 0.9.6.1 * Bug fix & issues notes for 0.11:

                  src\clientversion.h

                  That definition is used only, if there is no bitcoin-config.h, which in turn is created/updated by the autoconfig scripr, so the definitions in src\clientversion.h are never used.

                  Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
                  Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

                  AcidD 1 Reply Last reply Reply Quote 0
                  • AcidD
                    AcidD Moderators @Wellenreiter last edited by

                    @Wellenreiter said in [Dev] Feathercoin 0.9.6.1 * Bug fix & issues notes for 0.11:

                    @lizhi said in [Dev] Feathercoin 0.9.6.1 * Bug fix & issues notes for 0.11:

                    src\clientversion.h

                    That definition is used only, if there is no bitcoin-config.h, which in turn is created/updated by the autoconfig scripr, so the definitions in src\clientversion.h are never used.

                    I think Lizhi might be right. Also we have a slight problem.
                    https://github.com/FeatherCoin/Feathercoin/blob/0.9.6/src/feathercoind-res.rc

                    #include <windows.h>             // needed for VERSIONINFO
                    #include "clientversion.h"       // holds the needed client version information
                    

                    https://github.com/FeatherCoin/Feathercoin/blob/0.9.6/src/clientversion.h

                    // These need to be macros, as version.cpp's and bitcoin-qt.rc's voodoo requires it
                    #define CLIENT_VERSION_MAJOR       0
                    #define CLIENT_VERSION_MINOR       9
                    #define CLIENT_VERSION_REVISION    3
                    #define CLIENT_VERSION_BUILD       99
                    
                    // Set to true for release, false for prerelease or test build
                    #define CLIENT_VERSION_IS_RELEASE  false
                    
                    // Copyright year (2009-this)
                    // Todo: update this when changing our copyright comments in the source
                    #define COPYRIGHT_YEAR 2016
                    
                    

                    and my release Feathercoin-qt.exe
                    Wrong Version

                    Look at the version, it’s wrong. and matches what Lizhi was saying.

                    • FTC Block Explorer + API @ https://fsight.chain.tips
                    • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
                    • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
                    • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

                    1 Reply Last reply Reply Quote 0
                    • AcidD
                      AcidD Moderators last edited by

                      confirmed, changing the details in
                      https://github.com/FeatherCoin/Feathercoin/blob/0.9.6/src/clientversion.h

                      Now the right version and copyright date appear. Good find @lizhi !!

                      alt text

                      • FTC Block Explorer + API @ https://fsight.chain.tips
                      • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
                      • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
                      • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

                      Wellenreiter 1 Reply Last reply Reply Quote 0
                      • Wellenreiter
                        Wellenreiter Moderators @AcidD last edited by

                        @aciddude

                        also read lines 1 -5 of that file:

                        #ifndef CLIENTVERSION_H
                        #define CLIENTVERSION_H
                        
                        #if defined(HAVE_CONFIG_H)
                        //
                        
                        // These need to be macros, as version.cpp's and bitcoin-qt.rc's voodoo requires it
                        #define CLIENT_VERSION_MAJOR       0
                        #define CLIENT_VERSION_MINOR       9
                        #define CLIENT_VERSION_REVISION    3
                        #define CLIENT_VERSION_BUILD       99
                        

                        There are some lines missing:

                        #if defined(HAVE_CONFIG_H)
                        #include "bitcoin-config.h" 
                        #else
                        
                        .....
                        

                        is the right syntax

                        Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
                        Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

                        AcidD 1 Reply Last reply Reply Quote 0
                        • AcidD
                          AcidD Moderators @Wellenreiter last edited by

                          @Wellenreiter said in [Dev] Feathercoin 0.9.6.1 * Bug fix & issues notes for 0.11:

                          There are some lines missing:

                          #if defined(HAVE_CONFIG_H)
                          #include "bitcoin-config.h" 
                          #else
                          
                          .....
                          

                          is the right syntax

                          will it need to be changed in the .rc files as well?

                          i think there’s three for feathercoind, cli, qt.exe

                          https://github.com/FeatherCoin/Feathercoin/blob/0.9.6/src/feathercoind-res.rc

                          #include <windows.h>             // needed for VERSIONINFO
                          #include "clientversion.h"       // holds the needed client version information
                          
                          #define VER_PRODUCTVERSION     CLIENT_VERSION_MAJOR,CLIENT_VERSION_MINOR,CLIENT_VERSION_REVISION,CLIENT_VERSION_BUILD
                          #define VER_PRODUCTVERSION_STR STRINGIZE(CLIENT_VERSION_MAJOR) "." STRINGIZE(CLIENT_VERSION_MINOR) "." STRINGIZE(CLIENT_VERSION_REVISION) "." STRINGIZE(CLIENT_VERSION_BUILD)
                          #define VER_FILEVERSION        VER_PRODUCTVERSION
                          #define VER_FILEVERSION_STR    VER_PRODUCTVERSION_STR
                          #define COPYRIGHT_STR          "Feathercoin developers 2013-" STRINGIZE(COPYRIGHT_YEAR) ", The Bitcoin developers 2009-" STRINGIZE(COPYRIGHT_YEAR)   
                          
                          • FTC Block Explorer + API @ https://fsight.chain.tips
                          • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
                          • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
                          • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

                          1 Reply Last reply Reply Quote 1
                          • Wellenreiter
                            Wellenreiter Moderators last edited by

                            according to the piece of code you copied it should be ok.
                            If clientversion.h is patched in the qt-directory, it uses the values defined by the confiugure script and we only have one place to change the version numbers

                            Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
                            Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

                            1 Reply Last reply Reply Quote 1
                            • AcidD
                              AcidD Moderators last edited by

                              @Wellenreiter and I have been working on the sendAlert call which is used to send alerts across the Feathercoin Network.

                              I Believe we’ve solved this. Wellenreiter was able to send an alert over the TestNet and he received it on his node.

                              There was an issue with one of the blocks on the testnet so that’s just being fixed…one that’s done I should hopefully be able to connect to the TestNet Node Wellenreiter set up and receive his test message.

                              Then we can apply the same patch to prod. :)

                              • FTC Block Explorer + API @ https://fsight.chain.tips
                              • FTC Beer Money: 6x4LEQV88zRnBvZoH6ZNK6SeRxx4KiTyJs
                              • FTC bech32 address: fc1q4tclm3cv4v86ez6el76ewmharexfapxhek5a03
                              • BTC bech32 address: bc1qk8umuccapuafspk9e5szahvp0detafuzugv4ay

                              1 Reply Last reply Reply Quote 3
                              • wrapper
                                wrapper Moderators last edited by

                                Just a note to double check FTC code for this issue LTC #293 - List of FTC custom settings?

                                https://github.com/litecoin-project/litecoin/blob/master/src/main.cpp#L4161

                                main.cpp nCheckDepth #293

                                In the code it says
                                nCheckDepth = 1000000000; // suffices until the year 19000

                                But Litecoin is 4x faster then Bitcoin.
                                The note should say “until the year 4750”

                                or should the nCheckDepth be changed into 4000000000 s

                                https://github.com/litecoin-project/litecoin/issues/293#issuecomment-285490529

                                1 Reply Last reply Reply Quote 0
                                • wrapper
                                  wrapper Moderators last edited by wrapper

                                  Release of New Feathercoin Wallet version 0.9.6.1

                                  @Wellenreiter has started to lock down the code for the release of version 0.9.6.1.

                                  Reviewed outstanding document updates and policy.

                                  The FTC software settings, naming conventions and software development fork procedure showed that a lot of work is need to up keep Feathercoin name interface changes. Some changes such as comments, or where Feathercoin operates the same as Bitcoin core are unnecessary. How to handle files in the future for cherry pick or updates from head were discussed.

                                   /doc
                                   /doc/release-notes
                                  

                                  ToDo :

                                  • Include Feathercoin 0.9.6.1 release notes

                                  • Create Beta test builds / Window / MAC etc

                                  • Review - update Wallet guide, MultiSig is an important, but complex update, needs better screen shots / help text.
                                    https://github.com/wrapperband/FeathercoinWalletGuide#multisig-button
                                    * Review / consider - Include 5, 7 name Multisignature addresses i.e do further update

                                  * Multisig: A beginner’s guide
                                  https://99bitcoins.com/multisig-a-beginners-guide/

                                  • Note : 0.9.6.1 will be a long term version, compatible as a wallet with 0.11. The most usefull cases for Multisig, once you have got over the learning curve, is for more names, and say 3 out of 5, so there is redundancy for fund handling or other open source management / DAO criteria.

                                  • Review wither to including Feathercoin Wallet Guide in release

                                  Wellenreiter 1 Reply Last reply Reply Quote 0
                                  • Wellenreiter
                                    Wellenreiter Moderators @wrapper last edited by

                                    @wrapper said in [Dev] Feathercoin 0.9.6.1 * Bug fix & issues notes for 0.11:

                                    Review wither to including Feathercoin Wallet Guide in release

                                    I’d prefer to just include a link to the online guilde in the wallet-GUI. it gives more flexibility and enables us to update/enhance the guide without releasing new versions of the Wallet

                                    Feathercoin development donation address: 6p8u3wtct7uxRGmvWr2xvPxqRzbpbcd82A
                                    Openpgp key: 0x385C34E77F0D74D7 (at keyserver.ubuntu.com)/fingerprint: C7B4 E9EA 17E1 3D12 07AB 1FDB 385C 34E7 7F0D 74D7

                                    1 Reply Last reply Reply Quote 1
                                    • wrapper
                                      wrapper Moderators last edited by wrapper

                                      ##- Please type your reply above this line -##
                                      Email to shapeshift

                                      Jun 28, 2:54 AM MDT

                                      Feathercoin has spent considerable bounties to include shapeshift, for over one year. We understood FTC was to be reinstated after you had some problems.
                                      The next release is to be finalised within 5 days and it will then be about 6 months before it can be reinstated.

                                      Wrapper Admin FTC forum/dev

                                      Hello from the ShapeShift.io Support Team!

                                      Urgent Note: https://www.facebook.com/notes/shapeshiftio/note-on-support-requests-for-the-weekend-of-june-16-2017/1321495071261253/

                                      Your request (64102) has been received and is being reviewed by our team. Please, only send in one ticket per issue - this is important to speed up your resolution time.

                                      To ensure you get the best support possible please be sure you have included the ShapeShift deposit address and the TXID (or Hash) of your deposit(s).
                                      ShapeShift Support is available 7 days a week from 11am-7pm EST. Support is available, but limited outside of those hours. Your request will be resolved within 3-4 days.

                                      AmDD 1 Reply Last reply Reply Quote 0
                                      • AmDD
                                        AmDD Regular Member @wrapper last edited by

                                        @wrapper said in [Dev] Feathercoin 0.9.6.1 * Bug fix & issues notes for 0.11:

                                        ##- Please type your reply above this line -##
                                        Email to shapeshift

                                        Jun 28, 2:54 AM MDT

                                        Feathercoin has spent considerable bounties to include shapeshift, for over one year. We understood FTC was to be reinstated after you had some problems.
                                        The next release is to be finalised within 5 days and it will then be about 6 months before it can be reinstated.

                                        Wrapper Admin FTC forum/dev

                                        Hello from the ShapeShift.io Support Team!

                                        Urgent Note: https://www.facebook.com/notes/shapeshiftio/note-on-support-requests-for-the-weekend-of-june-16-2017/1321495071261253/

                                        Your request (64102) has been received and is being reviewed by our team. Please, only send in one ticket per issue - this is important to speed up your resolution time.

                                        To ensure you get the best support possible please be sure you have included the ShapeShift deposit address and the TXID (or Hash) of your deposit(s).
                                        ShapeShift Support is available 7 days a week from 11am-7pm EST. Support is available, but limited outside of those hours. Your request will be resolved within 3-4 days.

                                        I also sent SHapeShift an email a few weeks ago about adding Feathercoin back. I didnt get a direct response yet.

                                        P2Pool Node: http://104.236.34.9:19327/ 0.5% fee

                                        1 Reply Last reply Reply Quote 2
                                        • wrapper
                                          wrapper Moderators last edited by wrapper

                                          Incorrect setting of minimum fee #181
                                          https://github.com/FeatherCoin/Feathercoin/issues/181

                                          In at least one place (in main.cpp) - FTC custom settings are required because of block time and reward scaling of Bitcoin parameters.

                                          Further, whilst reviewing an emergency change, comparison should be made with the Litecoin setting, to ensure the further scaling of coin reward is reflected in the minimum fees.

                                          This is very important as it is currently mode of failure of Bitcoin and we will be stuck with high fees till the next release.

                                          v0.8 https://github.com/FeatherCoin/Feathercoin/blob/master-0.8/src/main.cpp
                                          /** Fees smaller than this (in satoshi) are considered zero fee (for transaction creation) /
                                          int64 CTransaction::nMinTxFee = 2000000;
                                          /* Fees smaller than this (in satoshi) are considered zero fee (for relaying) */
                                          int64 CTransaction::nMinRelayTxFee = 2000000;

                                          v0.9 https://github.com/FeatherCoin/Feathercoin/blob/0.9.6/src/main.cpp
                                          /** Fees smaller than this (in satoshi) are considered zero fee (for transaction creation) /
                                          int64_t CTransaction::nMinTxFee = 1000000; // Override with -mintxfee
                                          /* Fees smaller than this (in satoshi) are considered zero fee (for relaying and mining) */
                                          int64_t CTransaction::nMinRelayTxFee = 1000000;

                                          In 0.8 but not 0.9 main.cpp

                                          // Feathercoin
                                          // To limit dust spam, add nBaseFee for each output less than DUST_SOFT_LIMIT
                                          BOOST_FOREACH(const CTxOut& txout, vout)
                                          if (txout.nValue < DUST_SOFT_LIMIT)
                                          nMinFee += nBaseFee;

                                          // Raise the price as the block approaches full
                                          

                                          if (nBlockSize != 1 && nNewBlockSize >= MAX_BLOCK_SIZE_GEN/2)

                                          1 Reply Last reply Reply Quote 0
                                          • wrapper
                                            wrapper Moderators last edited by wrapper

                                            Notes : Minimum fee issue / review

                                            Review src/util.h 0.9.x

                                             static const int64_t COIN = 100000000;
                                            

                                            https://github.com/FeatherCoin/Feathercoin/blob/0.9.6/src/main.h

                                            nBaseFee is the value you configure. In 0.9 default is 1000000
                                            
                                            int64_t nMinFee = (1 + (int64_t)nBytes / 1000) * nBaseFee
                                            

                                            Review main.cpp main.h 0.8.x

                                            https://github.com/FeatherCoin/Feathercoin/blob/master-0.8/src/main.h

                                              /** Dust Hard Limit, ignored as wallet inputs (mininput default) */
                                             static const int64 DUST_HARD_LIMIT = 1000; // 0.00001 FTC mininput
                                            
                                             /** Dust Soft Limit, allowed with additional fee per output */
                                            static const int64 DUST_SOFT_LIMIT = 100000; // 0.001 FTC
                                            

                                            Litcoin related issues and updates (over Bitcoin)

                                            Minimum Transaction Fee review

                                            https://github.com/litecoin-project/litecoin/commit/3ce57329263cd347ada29172947b23dfc787e898
                                            https://github.com/litecoin-project/litecoin/commit/378ff026d0fc5205b2e15d2c2b05534d013ef5c5
                                            https://github.com/litecoin-project/litecoin/commits/0.8?after=9cffb23c2d48d47bb67df78ea1164738b41e8c9d+69
                                            https://github.com/litecoin-project/litecoin/commit/f80351c3215014935c5836f7d90cc21af5fc0cdf
                                            https://github.com/litecoin-project/litecoin/commit/72b4e39c092b03abc5495b908f671b2ca8fe03cd
                                            https://github.com/litecoin-project/litecoin/commit/def3c9e53b20815c8eef0aef7c9315cdd4a889c6

                                            https://github.com/litecoin-project/litecoin/commit/70313dd1e7518d410dac30db4906aac4846520a7

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post