[Dev] Documenting Feathercoin Specific Software settings - Part 16

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed boost c++11 build error :: commit

Fixed boost c++11 build error - ambiguous overload in chainparams.cpp

Fixes this error:
chainparams.cpp: In constructor ‘CMainParams::CMainParams()’:
chainparams.cpp:85:52: error: ambiguous overload for ‘operator=’ (operand types are ‘std::vector<unsigned char>’ and ‘boost::assign_detail::generic_list<int>’)
base58Prefixes[PUBKEY_ADDRESS] = list_of(14); // FeatherCoin addresses start with F
^
In file included from /usr/include/c++/6.2.1/vector:69:0,
from serialize.h:21,
from bignum.h:9,
from chainparams.h:9,
from chainparams.cpp:6:
/usr/include/c++/6.2.1/bits/vector.tcc:167:5: note: candidate: std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const std::vector<_Tp, _Alloc>&) [with _Tp = unsigned char; _Alloc = std::allocator<unsigned char>]
vector<_Tp, _Alloc>::

https://github.com/FeatherCoin/Feathercoin/commit/1791804d77a71e9cc1060b2ce0210dc9407f4a6e

src/chainparams.cpp

 -        base58Prefixes[PUBKEY_ADDRESS] = list_of(14); // FeatherCoin addresses start with F
 -        base58Prefixes[SCRIPT_ADDRESS_OLD] = list_of(5);
 -        base58Prefixes[SCRIPT_ADDRESS] = list_of(5);
 -        base58Prefixes[SECRET_KEY] =     list_of(142);// 14+128
 -        base58Prefixes[EXT_PUBLIC_KEY] = list_of(0x04)(0x88)(0xBC)(0x26);
 -        base58Prefixes[EXT_SECRET_KEY] = list_of(0x04)(0x88)(0xDA)(0xEE);

Code removed

     //how to do feathercoin ?
 +        base58Prefixes[PUBKEY_ADDRESS] = std::vector<unsigned char>(1,14); // FeatherCoin addresses start with F
 +        base58Prefixes[SCRIPT_ADDRESS_OLD] = std::vector<unsigned char>(1,5);
   //  base58Prefixes[SCRIPT_ADDRESS] = list_of(96);
 +        base58Prefixes[SCRIPT_ADDRESS] = std::vector<unsigned char>(1,5);
 +        base58Prefixes[SECRET_KEY] =     std::vector<unsigned char>(1,142);// 14+128
 +        base58Prefixes[EXT_PUBLIC_KEY] = boost::assign::list_of(0x04)(0x88)(0xBC)(0x26).convert_to_container<std::vector<unsigned char> >();
 +        base58Prefixes[EXT_SECRET_KEY] = boost::assign::list_of(0x04)(0x88)(0xDA)(0xEE).convert_to_container<std::vector<unsigned char> >();

Code (was) replaced

 -        base58Prefixes[PUBKEY_ADDRESS] = list_of(65);
 +        base58Prefixes[PUBKEY_ADDRESS] = std::vector<unsigned char>(1,65);

 -        base58Prefixes[SCRIPT_ADDRESS] = list_of(196);
 +        base58Prefixes[SCRIPT_ADDRESS] = std::vector<unsigned char>(1,196);

 -        base58Prefixes[SECRET_KEY]     = list_of(193);//65+128
 +        base58Prefixes[SECRET_KEY]     = std::vector<unsigned char>(1,193);//65+128

 -        base58Prefixes[EXT_PUBLIC_KEY] = list_of(0x04)(0x35)(0x87)(0xCF);
 +        base58Prefixes[EXT_PUBLIC_KEY] = boost::assign::list_of(0x04)(0x35)(0x87)(0xCF).convert_to_container<std::vector<unsigned char> >();

 -        base58Prefixes[EXT_SECRET_KEY] = list_of(0x04)(0x35)(0x83)(0x94);
 +        base58Prefixes[EXT_SECRET_KEY] = boost::assign::list_of(0x04)(0x35)(0x83)(0x94).convert_to_container<std::vector<unsigned char> >();

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Update README.md :: commit

https://github.com/FeatherCoin/Feathercoin/commit/3d895ca2d79b4494f53afa37a02890cda65289dd

https://github.com/FeatherCoin/Feathercoin/commit/81d7655ee312e60efee398950d871f8ce19a4b81

README.md

 +release candidate

Minor text update

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed Issue #125; set staarting block to 556535 :: commit

#125; 0.9.3.2 - Test result – Help / SX Stealth search
If you search from 1 or a low number a message is shown :
Beginning Height must be greater than 556535.
A simple enhancement would be to fill 556535 into the start field …

https://github.com/FeatherCoin/Feathercoin/commit/0275468c8c26799f84afbddeb5cbeed3c1ebfbfc

src/qt/forms/debugdialog.ui

 +   <property name="text">
 +    <string>556535</string>
 +   </property>

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fix a bug in multi-sign page :: commit

fix a bug in multi-sign page
fix a bug in multi-sign page, It is on max os. (MAC OS)

https://github.com/FeatherCoin/Feathercoin/commit/01b65443a91922fa91758a344c746c4f7594d353

src/qt/multisigdialog.cpp

 -    ui->btnCreateAddr->setIcon(QIcon());

Code removed

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed Issue #126 :: commit

A search for stealth coins failed with crash.
How to replicate : help - SX Stealth search, set low 556536, set high 10000000
Start Feathercoin on the “Command Line”
message on command line start up :
StealthSecret(): Q EC_POINT_bn2point failed
Segmentation fault (core dumped)

https://github.com/FeatherCoin/Feathercoin/commit/7b775f3c8bb4532d8cd60de5cc2b5d53673f2f3f

src/qt/utilitydialog.cpp

 -    int i;
 -    for(i=nFromHeight2;i>=nFromHeight;i--)

+    while (pindex->nHeight >= nFromHeight)

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed Issue #122 :: commit

0.9.3.2 - Test SX stealth coin Search in Help
Enhance SX search by defaulting “end search field” to the latest block height number

https://github.com/FeatherCoin/Feathercoin/commit/52103ce00a6040008c461d2ffa6ea115fb80590e

src/qt/utilitydialog.cpp

 +    CBlockIndex *pindex = chainActive.Genesis();

 ui->setupUi(this);

+    pindex = mapBlockIndex[chainActive.Tip()->GetBlockHash()];
+    ui->addrEdit2->insert(QString("%1").arg(pindex->nHeight));
+

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed Issue #123 :: commit

Help - SX Search :
When you search for a stealth address, the information given seems incorrect.
After a wait (while the search happens, button goes blue) a message pops up
“Scan stealth transactions on Blockchain,Yes!!!”
No Stealth addresses were found for the wallet . Click OK and it exits :
Text needs updating : scan complete SX coins found for wallet or not

https://github.com/FeatherCoin/Feathercoin/commit/f6cbba726e8f70a9aed2e738f5a6f13e941ebd91

src/qt/utilitydialog.cpp

 -		        LogPrintf("Find a stealth transaction %s :reason %s  .\n",tx.GetHash().ToString(),reason);

 +		        LogPrintf("Found stealth transaction %s :reason %s  .\n",tx.GetHash().ToString(),reason);

Code replaced

 -    QMessageBox::information(NULL, tr("Wallet Message"), tr("Scan stealth transactions on blockchain,Yes!!!"), QMessageBox::Yes , QMessageBox::Yes);

 +    QMessageBox::information(NULL, tr("Wallet Message"), tr("%1 stealth transactions found on blockchain.").arg(numberSxTransaction), QMessageBox::Yes , QMessageBox::Yes);

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fixed boost c++11 build error - ambiguous overload in chainparams.cpp :: commit

Fixes this error:
chainparams.cpp: In constructor ‘CMainParams::CMainParams()’:
chainparams.cpp:85:52: error: ambiguous overload for ‘operator=’ (operand types are ‘std::vector<unsigned char>’ and ‘boost::assign_detail::generic_list<int>’)
base58Prefixes[PUBKEY_ADDRESS] = list_of(14); // FeatherCoin addresses start with F
^
In file included from /usr/include/c++/6.2.1/vector:69:0,
from serialize.h:21,
from bignum.h:9,
from chainparams.h:9,
from chainparams.cpp:6:
/usr/include/c++/6.2.1/bits/vector.tcc:167:5: note: candidate: std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const std::vector<_Tp, _Alloc>&) [with _Tp = unsigned char; _Alloc = std::allocator<unsigned char>]
vector<_Tp, _Alloc>::

https://github.com/FeatherCoin/Feathercoin/commit/c29adf99bbfe054608c37317294ceec4aab6720a

src/qt/transactionview.cpp

 -        QString program="./bitmessagemain ";

+	#if defined(Q_OS_LINUX)
+	  QString program="pybitmessage";
+	#else
+	  QString program="./bitmessagemain";
+	#endif

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add support for miniupnpc api version 14 :: commit

Merge pull request #147 The value of new arg ttl is set to 2 as it’s recommended default.

https://github.com/FeatherCoin/Feathercoin/commit/4ec46d045c14c7aa957c63b2ee2053ac97f16c2a

src/net.cpp

 -#else

 +#elif MINIUPNPC_API_VERSION < 14

Code replaced

 +#else
 +     /* miniupnpc 2.0 */
 +    int error = 0;
 +    devlist = upnpDiscover(2000, multicastif, minissdpdpath, 0, 0, 2, &error);

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fix relaypriority calculation error :: commit

Solves #127 Fix relaypriority calculation error #148

https://github.com/FeatherCoin/Feathercoin/commit/b0741f8d7fdd3afc37060ac71b1c61fd6ce6641e

src/coins.cpp

 -        if (coins.nHeight < nHeight) {
 -            dResult += coins.vout[txin.prevout.n].nValue * (nHeight-coins.nHeight);


 +        if (coins.nHeight <= nHeight) {
 +            dResult += (double)(coins.vout[txin.prevout.n].nValue) * (nHeight-coins.nHeight);

Code replaced