Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fix relaypriority calculation error :: commit

Solves #127 Fix relaypriority calculation error #148

https://github.com/FeatherCoin/Feathercoin/commit/b0741f8d7fdd3afc37060ac71b1c61fd6ce6641e

src/coins.cpp

- if (coins.nHeight < nHeight) { - dResult += coins.vout[txin.prevout.n].nValue * (nHeight-coins.nHeight); + if (coins.nHeight <= nHeight) { + dResult += (double)(coins.vout[txin.prevout.n].nValue) * (nHeight-coins.nHeight);

Code replaced

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Updated splash screen :: commit

https://github.com/FeatherCoin/Feathercoin/commit/e469e0b42032481911ec96cce6a4a7662bb30a8f

src/qt/res/images/*

src/qt/res/images/splash.1.png src/qt/res/images/splash.2.png

Deleted

src/qt/res/images/splash.png

Updated splash screen

src/qt/splashscreen.cpp

- pixPaint.setPen(QColor(200,200,200)); + pixPaint.setPen(QColor(54,134,190));

Code replaced

- Q_ARG(QColor, QColor(200,200,200))); + Q_ARG(QColor, QColor(54,134,190)));

Code replaced

Updated splash screen header spacing to fit new splash screen image :: commit

https://github.com/FeatherCoin/Feathercoin/commit/f3bb1baaf2984fac18f20fcc5d4f83fcb1761251

src/qt/splashscreen.cpp

- int paddingTop = 230; + int paddingTop = 260;

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Re-included autoreconf in ./autogen.sh :: commit

Re-included autoreconf in ./autogen.sh, included echo messages autoupdate is running

https://github.com/FeatherCoin/Feathercoin/commit/fdc52bc1c0e366f30c2c3f80af9128dcd556fdb1

autogen.sh

-# autoreconf -if --warnings=all +echo running autoreconf ..... +autoreconf -if --warnings=all autoupdate +echo +echo running autoupdate completed .....

Code replaced

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Accept blocks version 4 — Part 2 :: commit

https://github.com/FeatherCoin/Feathercoin/commits/0.9.6?after=f296bdcef38b8c0770b43d4edc012e8c7434ac49+139

src/main.cpp

+ CBlockIndex *pindex = chainActive.Tip(); + LogPrintf("SetBestChain: chainActive nHeight=%d,BlockHash=%s\n",pindex->nHeight,pindex->GetBlockHash().ToString()); + LogPrintf("SetBestChain: pindexNew nHeight=%d,BlockHash=%s,pprev nHeight=%d,BlockHash=%s\n",pindexNew->nHeight,pindexNew->GetBlockHash().ToString(),pindexNew->pprev->nHeight,pindexNew->pprev->GetBlockHash().ToString()); + + if ((pindex->nHeight +1)!=pindexNew->nHeight) + return true; + + LogPrintf("SetBestChain: pindexNew go.\n"); + + if (!ConnectTip(state,pindexNew)) + { + LogPrintf("SetBestChain: false.\n"); + return false; + } + + LogPrintf("SetBestChain: true.\n");

Code added

- if(block.nVersion < 2) + if ((block.nVersion !=2)&&(block.nVersion !=4)) + { + LogPrintf("AcceptBlockHeader,incorrect block version=%d \n",block.nVersion); + }

Code replaced, note this has been updated further

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Set release flag to false – commit

For normal development version false is default, until checked

https://github.com/FeatherCoin/Feathercoin/commit/124e871288f3f2ac8a7d9f1d75fa198eb58bf4ed

configure.ac

+define(_CLIENT_VERSION_IS_RELEASE, false)

Code replaced

Update configure.ac

https://github.com/FeatherCoin/Feathercoin/commit/f5a15e896621c3ad5d005648b65e74ddb920de1b

configure.ac

+define(_CLIENT_VERSION_IS_RELEASE, true)

Code replaced

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Changed paperwallet template and copyright strings : - commit

https://github.com/FeatherCoin/Feathercoin/commit/07525719698e379f2c721e8e6ffdc6a08468c843

src/qt/res/images/*

src/qt/res/images/paper_wallet.png

Paper wallet image updated

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

plugin and base40 encode : - commit

https://github.com/FeatherCoin/Feathercoin/commit/386f5cc1dc3d25bab04c44fc5d84abd269ad8f7b

src/wallet.h

- bool SelectSharedCoins(int64 nTargetValue, std::set<std::pair<const CWalletTx*,unsigned int> >& setCoinsRet, int64& nValueRet, const CCoinControl* coinControl=NULL) const; + bool SelectSharedCoins(int64 nTargetValue, std::set<std::pair<const CWalletTx*,unsigned int> >& setCoinsRet, int64_t& nValueRet, const CCoinControl* coinControl=NULL) const;

Code replaced

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add Multisgin Page : - commit

https://github.com/FeatherCoin/Feathercoin/commit/83737e90c292f18fe0285677cefbd70125492e1a

Include a multi-signature address Page

src/wallet.h

+#include "script.h"

Code added

+ + bool CreateRawTransaction(const std::vector<std::pair<CScript, int64> >& vecSend, CTransaction& txNew, + int64& nFeeRet, std::string& strFailReason, bool isMultiSig, CReserveKey& reservekey, const CCoinControl *coinControl=NULL); + + /* + * for shared wallet + */ + bool IsMyShare(const CTxIn& txin) const; + bool IsMyShare(const CTxOut& txout) const; + bool IsMyShare(const CTransaction& tx) const; + int64 GetSharedBalance() const; + int64 GetSharedUnconfirmedBalance() const; + int64 GetSharedImmatureBalance() const; + int64 GetSharedCredit(const CTxOut& txout) const + { + if (!MoneyRange(txout.nValue)) + throw std::runtime_error("CWallet::GetSharedCredit() : value out of range"); + return (IsMyShare(txout) ? txout.nValue : 0); + } + bool IsFromMyShare(const CTransaction& tx) const + { + return (GetShareDebit(tx) > 0); + } + int64 GetShareDebit(const CTransaction& tx) const + { + int64 nDebit = 0; + BOOST_FOREACH(const CTxIn& txin, tx.vin) + { + nDebit += GetShareDebit(txin); + if (!MoneyRange(nDebit)) + throw std::runtime_error("CWallet::GetDebit() : value out of range"); + } + return nDebit; + } + int64 GetShareDebit(const CTxIn& txin) const; + void AvailableSharedCoins(std::vector<COutput>& vCoins, bool fOnlyConfirmed=true, const CCoinControl *coinControl=NULL) const; + bool SelectSharedCoins(int64 nTargetValue, std::set<std::pair<const CWalletTx*,unsigned int> >& setCoinsRet, int64& nValueRet, const CCoinControl* coinControl=NULL) const;

Code added

+ std::vector<CMerkleTx> vtxPrev; + std::vector<char> vfSpent; // which outputs are already spent + fSharedAvailableCreditCached = false;

Code added

+ + bool IsSpent(unsigned int nOut) const + { + if (nOut >= vout.size()) + throw std::runtime_error("CWalletTx::IsSpent() : nOut out of range"); + if (nOut >= vfSpent.size()) + return false; + return (!!vfSpent[nOut]); + }

Code added

+ + bool IsConfirmed() const + { + // Quick answer in most cases + if (!IsFinal()) + return false; + if (GetDepthInMainChain() >= 1) + return true; + if (!IsFromMe()) // using wtx's cached debit + return false; + + // If no confirmations but it's from us, we can still + // consider it confirmed if all dependencies are confirmed + std::map<uint256, const CMerkleTx*> mapPrev; + std::vector<const CMerkleTx*> vWorkQueue; + vWorkQueue.reserve(vtxPrev.size()+1); + vWorkQueue.push_back(this); + for (unsigned int i = 0; i < vWorkQueue.size(); i++) + { + const CMerkleTx* ptx = vWorkQueue[i]; + + if (!ptx->IsFinal()) + return false; + if (ptx->GetDepthInMainChain() >= 1) + continue; + if (!pwallet->IsFromMe(*ptx)) + return false; + + if (mapPrev.empty()) + { + BOOST_FOREACH(const CMerkleTx& tx, vtxPrev) + mapPrev[tx.GetHash()] = &tx; + } + + BOOST_FOREACH(const CTxIn& txin, ptx->vin) + { + if (!mapPrev.count(txin.prevout.hash)) + return false; + vWorkQueue.push_back(mapPrev[txin.prevout.hash]); + } + } + return true; + }

Code added

+ + /* + * for shared wallet + */ + mutable bool fSharedAvailableCreditCached; + mutable int64 nSharedAvailableCreditCached; + int64 GetSharedAvailableCredit(bool fUseCache=true) const + { + // Must wait until coinbase is safely deep enough in the chain before valuing it + if (IsCoinBase() && GetBlocksToMaturity() > 0) + return 0; + + //if (fUseCache && fSharedAvailableCreditCached) + //return nSharedAvailableCreditCached; + + int64 nCredit = 0; + for (unsigned int i = 0; i < vout.size(); i++) + { + if (!IsSpent(i)) + { + const CTxOut &txout = vout[i]; + nCredit += pwallet->GetSharedCredit(txout); + if (!MoneyRange(nCredit)) + throw std::runtime_error("CWalletTx::GetSharedAvailableCredit() : value out of range"); + } + } + + nSharedAvailableCreditCached = nCredit; + fSharedAvailableCreditCached = true; + return nCredit; + }

Code added

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Fix sx and CKey/CPubKey : - commit

https://github.com/FeatherCoin/Feathercoin/commit/55252135009938926532ddeabb3ac52d991b4381

src/qt/signverifymessagedialog.cpp

+ //CPubKey pubkey; + CKey key; + //if (!pubkey.RecoverCompact(Hash(ss.begin(), ss.end()), vchSig)) + if (!key.SetCompactSignature(Hash(ss.begin(), ss.end()), vchSig))

Code replaced

+ //if (!(CBitcoinAddress(pubkey.GetID()) == addr)) + if (!(CBitcoinAddress(key.GetPubKey().GetID()) == addr))

Code replaced

@wrapper said in [Dev] Documenting Feathercoin Specific Software settings - Part 7:

Code replaced

moc_reportview.cpp \ moc_reportview.cpp moc_merchantlist.cpp

The moc_* files are created during compile and should be added to the .gitignore file

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Define to 0 libzxing : - commit

https://github.com/FeatherCoin/Feathercoin/commit/b9528bb6426bf759d2ca241c0b49f50e8cea9cca

configure.ac

- define(_USE_ZXING,1) + define(_USE_ZXING,0)

Code replaced

- AC_DEFINE(USE_ZXING, _USE_ZXING,[Define to 1 libzxing must be available for support]) + AC_DEFINE(USE_ZXING, _USE_ZXING,[Define to 0 libzxing must be available for support])

Code replaced

@wrapper

Copyright was updated in a later commit the zxing flag was removed in a later commit qrflag triggers use of zxing then

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add lock/unlock menu : - commit

https://github.com/FeatherCoin/Feathercoin/commit/6f0ff3bb8b59d5955d1fcb9614ed9259061ca882

src/qt/walletview.h

+ /** Lock the wallet */ + void lockWallet();

@Wellenreiter said in [Dev] Feathercoin Web Site & Forum - Issues and Improvement:

@aciddude said in [Dev] Feathercoin Web Site & Forum - Issues and Improvement:

Back on topic…

Right now there is an issue with the Forum not displaying images correctly…

https://snag.gy/QoukLq.jpg

@Wellenreiter @wrapper

First Idea: it’s a network problem, or a Cloudflare problem.

A simple reload of the page should solve that for the user.
Possible reasons are:

Network/ internet bandwidth problem Browser cache problem ( seen myself with Opera) too many connections from the same node ( Opera opens up to 9 parallel connections in default config)

This was actually my ISP. Vodafone UK now provide internet to residential users…they have fast fibre on a good deal. Unfortunately they have some weird traffic filtering… an easy way to get around this is simply to switch DNS servers.

The main reason the images were not loading is those specific images come from https://i.imgur.com and Vodafone is trying to filter out user uploaded content sites…wankers!!

8.8.8.8
8.8.4.4

happy days!

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

team working with Bitmessage

https://github.com/FeatherCoin/Feathercoin/commit/78699b2fa3b63e225f2dd90944bee04dbd8124d0

src/qt/transactionview.h

+ void sendMess();

additional code

Add Implemented ACP and neoscrypt commit
https://github.com/FeatherCoin/Feathercoin/commit/c8ca4c906144910c62acd34e23a4ed624c0fbf7d

src/util.h

ACP and neoscrypt commit.

+extern bool fNeoScrypt;

Addition neoscrypt variable.

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

https://github.com/FeatherCoin/Feathercoin/commit/516a78744d2eac208b61a864f81d59dc9055568d

src/qt/bitcoingui.cpp

Add MerchantListView FTC reports commit

- tabGroup->addAction(accountReportAction);

Bitcoin code replaced reports

+ tabGroup->addAction(accountReportAction); + + merchantListAction = new QAction(QIcon(":/icons/merchantList"), tr("&MerchantList"), this); + merchantListAction->setStatusTip(tr("Print merchant list")); + merchantListAction->setToolTip(merchantListAction->statusTip()); + merchantListAction->setCheckable(true); + merchantListAction->setShortcut(QKeySequence(Qt::ALT + Qt::Key_6)); + tabGroup->addAction(merchantListAction);

Bitcoin code replaced reports

+ connect(merchantListAction, SIGNAL(triggered()), this, SLOT(showNormalIfMinimized())); + connect(merchantListAction, SIGNAL(triggered()), this, SLOT(gotoMerchantListPage())); +

FTC reports code added

- QMenu *file = appMenuBar->addMenu(tr("&File")); + QMenu *file = appMenuBar->addMenu(tr("&Wallet"));

Bitcoin code replaced.

- file->addAction(signMessageAction); - file->addAction(verifyMessageAction); + file->addSeparator(); + file->addAction(encryptWalletAction); + file->addAction(changePassphraseAction);

Bitcoin code replaced, scrypt?

+ settings->addAction(optionsAction); + settings->addSeparator();

Code added

- settings->addAction(changePassphraseAction);

Bitcoin code removed.

+ settings->addAction(signMessageAction); + settings->addAction(verifyMessageAction); settings->addSeparator(); settings->addSeparator(); settings->addAction(openRPCConsoleAction);

Replace Bitcoin code

- settings->addAction(optionsAction); - QMenu *help = appMenuBar->addMenu(tr("&Help")); - help->addAction(openRPCConsoleAction);

Bitcoin code removed

+ QMenu *advanced = appMenuBar->addMenu(tr("&Advanced")); + advanced->addAction(accountReportAction); + advanced->addSeparator(); + advanced->addAction(merchantListAction); } } + + QMenu *help = appMenuBar->addMenu(tr("&Help"));

Code added

+ toolbar->addAction(merchantListAction); + merchantListAction->setEnabled(enabled); + void BitcoinGUI::gotoMerchantListPage() + { + merchantListAction->setChecked(true); + if (walletFrame) walletFrame->gotoMerchantListPage(); + } +

Code added

This page needs updating to latest release 0.9.6 and proposed 0.9.6.1

To avoid confusion with old or development issues I’ve started a new thread, for web site and forum developments.

http://forum.feathercoin.com/topic/8895/dev-feathercoin-web-site-forum-issues-and-improvement