[Dev] Documenting Feathercoin Specific Software settings - Part 8

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

fix code : - commit

https://github.com/FeatherCoin/Feathercoin/commit/eae29b86c9ae0ecd550e1088393526cfa55a97b6

fix code

src/main.cpp

 -    //if (!CheckProofOfWork(block.GetHash(), block.nBits))
 -    //if (!CheckProofOfWork(block.GetPoWHash(), block.nBits))

Commented out code removed

  // Feathercoin: eHRC at 3rd hard fork

 -//int64_t nTargetTimespan = 60; // Feathercoin: 1 minute 
 -//int64_t nTargetSpacing = 60; // Feathercoin: 1 minute

Commented out code removed

 -static const int64_t nTargetTimespanNEW = 60 ; // Feathercoin: unused

Code removed

 -static const int64_t nDiffChangeTarget = 145000; // Feathercoin: unused ,Patch effective @ block 145000
 -static const int64_t nTestnetResetTargetFix = 157500; // Feathercoin: unused ,Testnet enables target reset at block 157500

Code removed

 -//0.8.7 ACP code have some problem in 0.9.3,so I delete them.

Comment removed

 -    //if (!pblocktree->WriteDiskBlockIndex(CDiskBlockIndex(pindexNew)) || !pblocktree->WriteBlockIndex(*pindexNew))

 -    //if (!pblocktree->WriteBlockIndex(CDiskBlockIndex(pindexNew)))

Commented code removed

 - LogPrintf("CBlockHeader::CheckProofOfWork(), nHeight=%i \n",nHeight);
 + //LogPrintf("CBlockHeader::CheckProofOfWork(), nHeight=%i \n",nHeight);

Code commented out

  -    //if (fCheckPOW && !CheckProofOfWork(block.GetPoWHash(), block.nBits))
  -    //if (fCheckPOW && !CheckProofOfWork(GetPoWHash(), nBits))

Commented out code removed

 -        // auxpow is not in memory, load CDiskBlockHeader
 -        // from database to get it
 -
 -        //Feathercoin unused
 -        //pblocktree->ReadDiskBlockIndex(*phashBlock, diskblockindex);
 -        //block.auxpow = diskblockindex.auxpow;

Commented out code removed

 -    //from dogecoin
 -    /*if (!CheckBlock(*pblock, state, INT_MAX)) {  
 -        if (state.CorruptionPossible())
 -            mapAlreadyAskedFor.erase(CInv(MSG_BLOCK, hash));
 -        return error("ProcessBlock() : CheckBlock FAILED");
 -    }*/
 -    //if (!CheckBlock(*pblock, state,nForkFour-1))
 -    //if (!CheckBlock(*pblock, state,1))

Commented out code removed

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

fix code : - commit

https://github.com/FeatherCoin/Feathercoin/commit/eae29b86c9ae0ecd550e1088393526cfa55a97b6

fix code

src/qt/Makefile.am

 +  forms/commentdialog.ui \

Add code.

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/crypter.h

No change, white space removed

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/key.h

 +    // Simply read-only vector-like interface to the pubkey data.

Unnecessary change to a comment?

 -        ::WriteCompactSize(s, len);

 +        //::WriteCompactSize(s, len);
 +        ::Serialize(s, VARINT(len), nType, nVersion);

Code replaced

 -        unsigned int len = ::ReadCompactSize(s);

 +        //unsigned int len = ::ReadCompactSize(s);
 +        unsigned int len;
 +        ::Unserialize(s, VARINT(len), nType, nVersion);

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/main.cpp

 -            //from bitcoin
 -            //if (!AddToBlockIndex(block, state, blockPos))
 -            //    return error("InitBlockIndex AddToBlockIndex() : genesis block not accepted");
 -            //from dogecoin

Code removed

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/Makefile.am

 +  forms/debugdialog.ui \

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/bitcoingui.cpp

 +    debugAction = new QAction(QIcon(":/icons/comment"), tr("&Debug"), this);
 +    debugAction->setStatusTip(tr("Debug Feathercoin"));

 +        connect(debugAction, SIGNAL(triggered()), walletFrame, SLOT(debugClicked()));

 +    help->addAction(debugAction);

 +    debugAction->setEnabled(enabled);

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/bitcoingui.h

 +    QAction *debugAction;

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/forms/debugdialog.ui

New user interface file

 + <?xml version="1.0" encoding="UTF-8"?>
 + <ui version="4.0">
 +  <class>DebugDialog</class>
 +  <widget class="QDialog" name="DebugDialog">
 +   <property name="geometry">
 +    <rect>
 +     <x>0</x>
 +     <y>0</y>
 +     <width>556</width>
 +     <height>208</height>
 +    </rect>
 +   </property>
 +   <property name="windowTitle">
 +    <string>Debug Dialog (experts only!)</string>
 +   </property>
 +   <widget class="QPushButton" name="sxButton">

Start of code new file , 106 lines of code

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/utilitydialog.cpp

 + #include "ui_debugdialog.h"

 + #include "wallet.h"

 + /** "DebugDialog" dialog box */
 + DebugDialog::DebugDialog(QWidget *parent) :
 +     QDialog(parent),
 +     ui(new Ui::DebugDialog)
 + {
 +     ui->setupUi(this);
 + }
 + 
 + void DebugDialog::setModel(WalletModel *model)
 + {
 +     this->model = model;
 + }
 + 
 + DebugDialog::~DebugDialog()
 + {
 +     delete ui;
 + }
 + 
 + void DebugDialog::on_pushButton_clicked()
 + {
 +     close();
 + }
 + 
 + void DebugDialog::on_sxButton_clicked()
 + {
 + 		int32_t nFromHeight = 566321;
 + 		if (ui->addrEdit->text().length()>0)
 + 		{
 + 			nFromHeight = ui->addrEdit->text().toInt();
 + 		}
 +     bool fUpdate = true;
 +     CBlockIndex *pindex = chainActive.Genesis();
 +     
 +     if (nFromHeight > 0)
 +     {
 +         pindex = mapBlockIndex[chainActive.Tip()->GetBlockHash()];
 +         //pindex = chainActive[nFromHeight];
 +         while (pindex->nHeight > nFromHeight && pindex->pprev)
 +             pindex = pindex->pprev;
 +     };
 +     
 +     LogPrintf("Scan open from %d ................\n",pindex->nHeight); 
 +     CBlock block;
 +     if (!ReadBlockFromDisk(block, pindex))
 +     {
 +     	LogPrintf("ReadBlockFromDisk failure.\n"); 
 +     	return;
 +     } 
 +     LogPrintf("block.vtx.size= %d ................\n",block.vtx.size()); 
 +     BOOST_FOREACH(CTransaction& tx, block.vtx)
 +     { 
 +         string reason;
 +         if (!IsStandardTx(tx, reason))
 +         {
 +         		LogPrintf("Standard transaction %s :reason %s  .\n",tx.GetHash().ToString(),reason);
 +             continue; // leave out coinbase and others       
 +         }
 +         LogPrintf("Find stealth transaction %s :reason %s  .\n",tx.GetHash().ToString(),reason); 
 +         pwalletMain->AddToWalletIfInvolvingMe(tx.GetHash(), tx, &block, fUpdate);
 +     };
 +     
 +     QMessageBox::information(NULL, tr("Wallet Message"), tr("Scan stealth transactions,Yes!!!"), QMessageBox::Yes , QMessageBox::Yes);
 + }
 + 
 + 
 +

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/utilitydialog.h

 +     class DebugDialog;

 + /** "DebugDialog" dialog box */
 + class DebugDialog : public QDialog
 + {
 +     Q_OBJECT
 + 
 + public:
 +     explicit DebugDialog(QWidget *parent);
 +     ~DebugDialog();
 + 
 +     void setModel(WalletModel *model);
 + 
 + private:
 +     Ui::DebugDialog *ui;
 +     WalletModel *model;
 + 
 + private slots:
 +     void on_sxButton_clicked();
 +     void on_pushButton_clicked();
 +     
 + signals:
 +     void message(const QString &title, const QString &message, unsigned int style);
 + };
 +

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/walletframe.cpp

 + void WalletFrame::debugClicked()
 + {
 +     WalletView *walletView = currentWalletView();
 +     if (walletView)
 +         walletView->debugClicked();
 + }
 +

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/walletframe.h

 +    /** Open Debug dialog **/
 +    void debugClicked();

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/walletmodel.cpp

 +                    LogPrintf("StealthSecret send start....\n");

Logprintf added

 +     if (true)
 +        {
 +          LogPrintf("ephem_secret.e[0]=%s \n",ephem_secret.e[0]);   //secret
 +          LogPrintf("sxAddr.scan_pubkey= %s\n", HexStr(sxAddr.scan_pubkey).c_str()); //pubkey[0]
 +          LogPrintf("sxAddr.spend_pubkey= %s\n", sxAddr.spend_pubkey[0]); //pkSpend[0]
 +          LogPrintf("secretShared.e[0]=%s \n",secretShared.e[0]);  //sharedSOut
 +          LogPrintf("pkSendTo= %"PRIszu": %s\n", pkSendTo.size(), HexStr(pkSendTo).c_str());//pkOut
 +

Code added

 +    LogPrintf("CPubKey(pkSendTo)=%s \n",cpkTo.GetHash().ToString().c_str());

Code added

  -   CKeyID ckidTo = cpkTo.GetID();
 +      CKeyID ckidTo = cpkTo.GetID();

Code replaced, not sure why?

 +     LogPrintf("Stealth send to generated pubkey,pkSendTo= %"PRIszu": %s\n", pkSendTo.size(), HexStr(pkSendTo).c_str());

 +   LogPrintf("hash, Address= %s\n", addrTo.ToString().c_str());

 +  LogPrintf("enerate ephem public key,ephem_pubkey= %"PRIszu": %s\n", ephem_pubkey.size(), HexStr(ephem_pubkey).c_str());

Replace LogPrintf code

 -            //scriptPubKey.SetDestination(CBitcoinAddress(rcp.address.toStdString()).Get());

Remove code

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/walletview.cpp

 + }
 + 
 + void WalletView::debugClicked()
 + {
 +     if(!walletModel)
 +         return;
 + 
 +     DebugDialog dlg(this);
 +     dlg.setModel(walletModel);
 +     dlg.exec();

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/qt/walletview.h

 +    /** Open Debug dialog **/
 +    void debugClicked();

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/rpcclient.cpp

 +     if (strMethod == "sendtostealthaddress"   && n > 1) ConvertTo<double>(params[1]);
 +     if (strMethod == "scanforstealthtxns"     && n > 0) ConvertTo<int>(params[0]);
 +     if (strMethod == "scanforalltxns"         && n > 0) ConvertTo<int>(params[0]);

Code added

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/rpcwallet.cpp

 -        result.push_back(Pair("result", "Invalid Deepcoin stealth address."));
 +        result.push_back(Pair("result", "Invalid Feathercoin stealth address."));

Deepcoin code replaced Feathercoin ?? Translations?

 +        pindex = mapBlockIndex[chainActive.Tip()->GetBlockHash()];//[hashBestChain];

Code replaced

 +    printf("Scan open from %d ................\n",nFromHeight);

Code added

 +        ReadBlockFromDisk(block, pindex);  //block.ReadFromDisk(pindex);
 +        printf("pindex->nHeight=%d \n",pindex->nHeight);

Code added

 +    typedef boost::tuple<uint256, std::vector<unsigned char>, std::vector<unsigned char> > sigdata_type;

 +    Get(uint256 hash, const std::vector<unsigned char>& vchSig, const std::vector<unsigned char>& pubKey)

 +    void Set(uint256 hash, const std::vector<unsigned char>& vchSig, const std::vector<unsigned char>& pubKey)

 +bool CheckSig(vector<unsigned char> vchSig, vector<unsigned char> vchPubKey, CScript scriptCode,

 + /*   CPubKey pubkey(vchPubKey);
 +        return false;  */


 +    if (signatureCache.Get(sighash, vchSig, vchPubKey))


 +    if (!CPubKey(vchPubKey).Verify(sighash, vchSig))

 +        signatureCache.Set(sighash, vchSig, vchPubKey);

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog, various rv parameter definitions are changed

src/stealth.cpp

 -    Q = dG
 +    Q = dG  //µ¥´ÎÊ¹ÓÃµÄË½Ô¿

Code replaced

 -        rv = 1;
 +        rv = 2;

Code replaced

 -        rv = 1;
 +        rv = 3;

Code replaced

wrapper

Feathercoin specific changes made to convert Bitcoin to FTC 0.9.6.*

Add debug dialog : - commit

https://github.com/FeatherCoin/Feathercoin/commit/53644b506ce7b817a4135633184bd3d678b390d5

debug dialog

src/wallet.cpp

 +        LogPrintf("AddToWalletIfInvolvingMe,hash=%s .\n",hash.ToString());

Code added

 -    if (fDebug)
 -        printf("FindStealthTransactions() tx: %s\n", tx.GetHash().GetHex().c_str());

 +     LogPrintf("FindStealthTransactions() tx:%s,", tx.GetHash().GetHex().c_str());    

 +     if (tx.GetHash().GetHex().compare("85568ae1dacfdc6730b0d2ddeb2c4d7d07b0ac702e6d9a7f408293e2cd628d57")==1)
 +    	{
 +    		LogPrintf("no debug.\n");
 +     	return false;
 +     }

Code replaced

 -    ec_secret sShared;
 -    ec_point pkExtracted;

 +    ec_secret sShared;    
 +    ec_point pkExtracted;

Code replaced

 +         LogPrintf("BOOST_FOREACH nOutputIdOuter=%d ,find txout...\n", nOutputIdOuter);
 +         LogPrintf("txout scriptPubKey= %s\n",  txout.scriptPubKey.ToString().c_str()); //OP_RETURN 02fe58a19a83c9ce0fc129bfa0a6a53b3440b6f9eac357143b23be38b7779c53d2
 +         LogPrintf("txout hash = %s\n",  txout.GetHash().GetHex().c_str());  //5bada4eca0588e4dbb33ec37bd658dfdd7b9bce1e3ad3aa68461151f2e835597

Code replaced

 +        LogPrintf("in txout.scriptPubKey,check vchEphemPK=%s\n", HexStr(vchEphemPK).c_str()); //

Code added

 -        BOOST_FOREACH(const CTxOut& txoutB, tx.vout)
 +        BOOST_FOREACH(const CTxOut& txoutB, tx.vout) //tx.vout again

tx.vout removed

 +            LogPrintf("BOOST_FOREACH nOutputId=%d ,print param.....\n", nOutputId);

Code added

 -            if (&txoutB == &txout)
 +            if (&txoutB == &txout)  //把OP_RETURN交易分别与另2个执行

Comment add in chinese

 +             LogPrintf("CTxOut: %s\n", txoutB.ToString().c_str());
 +             LogPrintf("only 1 txn will match an ephem pk,tx.vout scriptPubKey %s\n",  txoutB.scriptPubKey.ToString().c_str());    
 +                //OP_DUP OP_HASH160 d0ae59f757fc9ce14559413e2d00ac8fede6f9a2 OP_EQUALVERIFY OP_CHECKSIG

Code added

 +            CKeyID ckidMatch = boost::get<CKeyID>(address);

Code replaced

 +            LogPrintf("CTxDestination=CKeyID,ckidMatch=%s \n", ckidMatch.ToString().c_str());
 +             //a2f9e6ed8fac002d3e415945e19cfc57f759aed0

+            int i=0;

 +                i++;
 +                LogPrintf("StealthAddress iterator=%d \n", i); //

 +                LogPrintf("it->scan_secret.size() %d\n",  it->scan_secret.size());
 +                LogPrintf("it->Encodeded() %s\n",  it->Encoded().c_str());  //找到收款人隐身公匙地址
 +                memcpy(&sScan.e[0], &it->scan_secret[0], ec_secret_size);

Code added

 +                 LogPrintf("StealthAddress Label=%s \n",it->label);
 +                 LogPrintf("StealthAddress Address=%s \n",it->Encoded());
 +                 LogPrintf("StealthAddress Scan Secret=%s \n",HexStr(it->scan_secret.begin(), it->scan_secret.end()));//f1e76e169c05b00ad755ef6128a1fe2ccc1f2351383f5a5969f4040994d3f25e
 +                 LogPrintf("StealthAddress Scan Pubkey=%s \n",HexStr(it->scan_pubkey.begin(), it->scan_pubkey.end()));//038cf92caa6f1fe56b19e09cca0bdc52a81e46007bc12622688c0feda804f9d073
 +                 LogPrintf("StealthAddress Spend Secret=%s \n",HexStr(it->spend_secret.begin(), it->spend_secret.end()));//117a9e4a428e7549eeeaa1dc3deb5cab2696518e2af0849fc6b7d675fe0a10ee
 +                 LogPrintf("StealthAddress Spend Pubkey=%s \n",HexStr(it->spend_pubkey.begin(), it->spend_pubkey.end()));
 +                     //02ffae1e8fda48c5ff6824ac0d497ea3c3b1ef3a438832bd5e5edc0bf4f93172d6,与OP_RETURN不匹配
             
             
 +                 LogPrintf("sScan.e=%s\n",sScan.e);   //收款人隐身公匙地址,secret
 +                 LogPrintf("vchEphemPK=%s\n", HexStr(vchEphemPK).c_str()); //pubkey[0],可能是个问题
 +                 LogPrintf("it->spend_pubkey=%s\n", HexStr(it->spend_pubkey)); //pkSpend[0] 02ffae1e8fda48c5ff6824ac0d497ea3c3b1ef3a438832bd5e5edc0bf4f93172d6
 +                 LogPrintf("sShared.e=%s\n",sShared.e);  //sharedSOut
 +                 LogPrintf("pkExtracted=%"PRIszu":%s\n", pkExtracted.size(), HexStr(pkExtracted).c_str());//pkOut
 +                  
 +                 int rv=StealthSecret(sScan, vchEphemPK, it->spend_pubkey, sShared, pkExtracted);
 +                 if (rv!= 0)
             {
             {
 +                     LogPrintf("StealthSecret failed.rv=%d \n",rv);
                 continue;
                 continue;
             };
             };
 +                 LogPrintf("StealthSecret ok.rv=%d \n",rv);
 +                 LogPrintf("pkExtracted= %"PRIszu": %s\n", pkExtracted.size(), HexStr(pkExtracted).c_str());//pkOut

Code replaced

 +                 CPubKey cpkE(pkExtracted);                

 +                 CKeyID ckidE = cpkE.GetID();                
             if (ckidMatch != ckidE)
             if (fDebug)
 +                 //if (fDebug)
 +                     LogPrintf("Found stealth txn to address %s\n", it->Encoded().c_str());

Code replaced