[Dev] Release Candidate Feathercoin 0.9.3.2 - Check List

Wellenreiter

Is this backwardly compatible with 0.8.7.3 ?

Or will we need to release and test 0.8.7.4 to ensure backward compatible to LTS versions of Linux?.

We should fade out the 0.8.x versions and come back to one production release only.
Maintaining two different versions will cost to much in resources.

ghostlander

I can maintain v0.8 as long as necessary.

Wellenreiter

@ghostlander said:

I can maintain v0.8 as long as necessary.

Thanks for that :D

wrapper

I’ve just seen this, so we also need to consider knock on consequences or changes, at least to give warning of fork level changes.

Bitcoin P2Pool Software : 18th June 2016 http://p2pool.in/

URGENT: Upgrade required

HARDFORK - Upgrade URGENTLY required in the next 24 hours.

Windows binary: http://u.forre.st/u/ovqxauzj/p2pool_win32_15.0.zip
Windows binary signature: http://u.forre.st/u/wynjbvpn/p2pool_win32_15.0.zip.sig
Source zipball: https://github.com/forrestv/p2pool/zipball/15.0
Source tarball: https://github.com/forrestv/p2pool/tarball/15.0

Changes:

BIP65/block version 4 compatibility
Requires Bitcoin >=0.11.2 (due to BIP65 compatibility)

BIP65 will take effect in the next week (as of Dec 6th) and in order for P2Pool to continue working without producing invalid blocks, everyone needs to upgrade. At 50% of our hashrate upgrading, P2Pool instances will start displaying a warning saying that an upgrade is required. Reaching that point as quickly as possible is very important. And then, at 95%, users that have not upgraded will be excluded. If non-upgraded users aren’t excluded before BIP65 takes effect, P2Pool users will be subject to paying other users for invalid work - effectively a withholding attack.

So, please upgrade to 15.0 now and also tell everyone else to.

Events such as this are announced via the P2Pool-notifications mailing list.

Wellenreiter

That was one of the reasons, that I upgraded the Feathercoin p2pool git reopsitory to version 15…

wrapper

I have made a number of updates , and have now re-based those so each is available a single path on a checkout of 0.9.3.2.

https://github.com/wrapperband/Feathercoin

I have pre-updated the about dialog, this was missed in 0.9.3.1, Copied over the notes and Tests to this thread from 0.9.3.1 thread.

Patches available to merge into test version.

https://github.com/wrapperband/Feathercoin/commits/0.9.3.2

aboutdialog.ui
https://github.com/wrapperband/Feathercoin/commit/f0c6f462085db7534470188d86448c0dd4c0e012

src/qt/forms/aboutdialog.ui
Showing the top match. Last indexed on 21 Mar.
<property name=“text”>
<string notr=“true”>Copyright © 2013-YYYY The Feathercoin Core developers</string>

The Version number on the About form is not a variable, I have updated it, but FTC release seems correct, did @Wellenreiter update the release build?

It doesn’t look like a variable, or does the make release do some stuff I don’t know about?.

Updated to latest (Dev) version 0.9.3.2

debugdialog.ui
https://github.com/wrapperband/Feathercoin/commit/e6e74b08695852dfe0506f2f031df78fee23b8db

I have tidied up the layout of debugdialog.ui

It is in the Help Menu SX Tool : It appears to by a sub dialog of the Shapeshift function, to search for shape shifted coins

I have changed the height to “block height” and re-aligned the buttons as other dialogs.

It needs testing, searching for shape shift coins.

opennamedialog.ui
https://github.com/wrapperband/Feathercoin/commit/74f262ac15548bf392d462ca06214349044c1fd1

I have Updated the Layout to opennamedialog.ui to be more standard, and the help text. Text needs double checking for clarity.

The dialog is for input open names.

Testing
Needs testing to see if I have correctly interpreted the help line.
Is it 40 Chars in total? or each as I have put

paperwalletdialog.ui
https://github.com/wrapperband/Feathercoin/commit/d38d7f9345be22cb772ce58bdad96da9e48f23bc

I have updated the layout of paperwalletdialog.ui removed “Dogecoin” references in the buttons. Move buttons to more standard positions.

Just tested that myself it is on File menu, print paper wallet. Needs further tweek to close button position.

Testing
Check you can still print a paper wallet
Feilds and number of wallet work when input out of spec.

What happens if you put 50 characters in?

shiftdialog.ui
https://github.com/wrapperband/Feathercoin/commit/78055c7579bbfbd3626bab680b2b30693ef22e83

Updated the Layout to Fixed transaction tab, shiftdialog.ui, returned tabs to main.

Requires double check when compiled

commentdialog.ui
https://github.com/wrapperband/Feathercoin/commit/25b924030f8112c30ac2b8ac6882bb132bf73279
I’ve further tidied up the comment dialogue, and checked the code that it calls.

It needs testing to confirm it all still works by setting a comment
also - Review how the input error checking works, by inputing other incorrect data.

wrapper

0.9.3.2 : Readme.md update :

I’ve added the Readme.md to 0.9.3.2 with text covering what is FTC development and which is Bitcoin.

Readme.md Feathercoin Fork Policy and Bitcoin Core Development Information
https://github.com/wrapperband/Feathercoin/commit/deede1266c0ede736ce5ecf998c74fa00f080612

INSTALL update

Updated 0.9.3.2 INSTALL instructions to Feathercoin
https://github.com/wrapperband/Feathercoin/commit/b491dff012d4987ffe5aa1c0cf6d3a1a0296ef0c

Wellenreiter

Please create pulls requests toward the feathercoin main repository for all changes so we can include them into the 0.9.3.2 branch and check for conflicts.

wrapper

I’'ll try and find out what creating a pull request is, I read the procedure was to email the maintainer you have a pull they might want, as I am not the FTC maintainer (still learning).

I’m trying to add a simple FTC build example in the 0.9.3.2 Doc readme, that includes the extra dependencies and settings needed to compile from source / PPA.

However, still not been able to set up a build from scratch from instructions for 0.9.3.2 on Ubuntu 16.04 , - so they need build testing by someone else before pulling.

Wellenreiter

@wrapper said:

I’'ll try and find out what creating a pull request is, I read the procedure was to email the maintainer you have a pull they might want, as I am not the FTC maintainer (still learning).

I’m trying to add a simple FTC build example in the 0.9.3.2 Doc readme, that includes the extra dependencies and settings needed to compile from source / PPA.

However, still not been able to set up a build from scratch from instructions for 0.9.3.2 on Ubuntu 16.04 , - so they need build testing by someone else before pulling.

creating a pull request is more or less easy.

commit and push your changes to github
access your fork on github via the web interface
select the branch you wher eworking on
- you should see a button 'new pull request> just at the right side of the branch name
- there should be a lit of you last changes near the top of the page together with a ‘create pull request’ button

When creating a pull request, be careful that you compare in the right direction.

the base fork should be ‘Feathercoin/0.9.3.2’ and the head fork <your repository>/0.9.3.2

When creating the system generates the notification emails

wrapper

Request for assistance Test and Guide production 0.9.3.2

/ how to compile / program Feathercoin :

Test and comments / improvement ideas for Feathercoin wallet user interface.
Test comments and patches to - Feathercoin Wallet Guide.

If testing on a live system, rename / backup your .feathercoin directory. This prevents problems with your live wallet, tests resync from scratch and provides fresh debug.log files for inspection.

Feathercoin 0.9.3.2 Guide to Features : Github

The Feathercoin help guide is in development, the latest version of the can be cloned from :

https://github.com/wrapperband/FeathercoinWalletGuide.git

How to Build wallet Test version :

Install Virtual Machine with Ubuntu 16.04

git clone https://github.com/Feathercoin/Feathercoin.git
git checkout 0.9.3.2

Install dependencies :

https://github.com/Feathercoin/Feathercoin/tree/0.9.3.2/doc

Build cycle

make clean
./autogen.sh
autoupdate
./configure  --enable-tests=no --with-gui=qt5 --enable-upnp-default --with-qrcode=no 
make

How to make UI changes

You can make updates to the interface, by installing and IDE.
Qt Creator is an easy to use IDE.
Simply open the interface files stored in Feathercoin/src/qt/forms as *.ui files.

How to save your changes to Github

Register with Github, it is free for open source use.
Fork the Feathercoin project to your own repository
https://Feathercoin/Feathercoin
Clone your fork to your own PC
Make changes to Code - Copy changed FTC code to a separate Build directory
git checkout 0.9.3.2
Build code cycle

how to run built code
cd Feathercoin
cd src
cd qt

     ./feathercoin-qt

AcidD

EDIT : Removed some nonsense I was talking and fixed the command so there’s no confusion.
Build Instructions further down…: http://forum.feathercoin.com/topic/8570/dev-release-candidate-feathercoin-0-9-3-2-check-list/34


  OBJCXXLD feathercoin-qt
libbitcoinqt.a(libbitcoinqt_a-snapwidget.o): In function `SnapWidget::on_snapButton_clicked()':
/home/aciddude/FTC0932/Feathercoin/src/qt/snapwidget.cpp:71: undefined reference to `zxing::String::getText[abi:cxx11]() const'
collect2: error: ld returned 1 exit status
Makefile:1203: recipe for target 'feathercoin-qt' failed
make[5]: *** [feathercoin-qt] Error 1

After some googling I found this:
http://stackoverflow.com/questions/30124264/undefined-reference-to-googleprotobufinternalempty-string-abicxx11

So I rebuilt Libzxing from this guy
https://github.com/glassechidna/zxing-cpp

and my build command for libzxing was

export CXXFLAGS="-fPIC"
cmake -G “Unix Makefiles” -DCMAKE_BUILD_TYPE=Release ..
sudo make 
sudo make install

I then copied the libzxing files to the Feathercoin/src/ folder and continued my make. It compiles and I can see QRcodes :-)

AcidD

So I’ve tested some of this on 0.9.3.2 Ubuntu 16.04 .

@wrapper said:

https://github.com/wrapperband/Feathercoin/commits/0.9.3.2

aboutdialog.ui
https://github.com/wrapperband/Feathercoin/commit/f0c6f462085db7534470188d86448c0dd4c0e012
Looks good.

debugdialog.ui
https://github.com/wrapperband/Feathercoin/commit/e6e74b08695852dfe0506f2f031df78fee23b8db
Looks good.

paperwalletdialog.ui
https://github.com/wrapperband/Feathercoin/commit/d38d7f9345be22cb772ce58bdad96da9e48f23bc
I was able to print a paper wallet. (print to PDF)
I was not able to input anything into the public key space nor was I able to delete what was there.
I was able to generate new addresses and make and print multiple wallets

AcidD

0.9.3.2 wallet fully synced in 2.5 hours.

Wallet sends and receives Feathercoins just fine :-)

here’s me tipping @Wellenreiter using 0.9.3.2
http://explorer.feathercoin.com/tx/ae7a76ea80f7f8b41c8be3fcb1850e7e0c4bf8d5cc2d9510740fc563107c0097#o0

I also did a comment to @Wellenreiter in this tx
http://explorer.feathercoin.com/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7#o1

Edit…I now know how to check for comments on the FTC block chain.

On my block explorer can see the transaction and I can copy and paste the OP_RETURN which was
49207265737065637420796f757220776f726b206475646521

http://fsight.chain.tips/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7

Hex to Ascii on OP_RETURN 49207265737065637420796f757220776f726b206475646521 = I respect your work dude!

AmDD

@aciddude 2.5 hours?? Very nice!!

wrapper

@Aciddude

I’ve added your zxing “build from source instructions” to an updated FTC wallet install from source guide in my [Dev] version of 0.9.3.2.

https://github.com/wrapperband/Feathercoin/tree/0.9.3.2/doc

Wellenreiter

@aciddude Great :)

So I rebuilt Libzxing from this guy
https://github.com/glassechidna/zxing-cpp

I will use that version of zxing to build my packages :)

Wellenreiter

@aciddude said:

0.9.3.2 wallet fully synced in 2.5 hours.

Wallet sends and receives Feathercoins just fine :-)

here’s me tipping @Wellenreiter using 0.9.3.2
http://explorer.feathercoin.com/tx/ae7a76ea80f7f8b41c8be3fcb1850e7e0c4bf8d5cc2d9510740fc563107c0097#o0

I also did a comment to @Wellenreiter in this tx
http://explorer.feathercoin.com/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7#o1

Edit…I now know how to check for comments on the FTC block chain.

On my block explorer can see the transaction and I can copy and paste the OP_RETURN which was
49207265737065637420796f757220776f726b206475646521

http://fsight.chain.tips/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7

Hex to Ascii on OP_RETURN 49207265737065637420796f757220776f726b206475646521 = I respect your work dude!

We should try to find a way to detect commends in the BC, do the conversion automatically and display the comment in the GUI

AcidD

@Wellenreiter said:

@aciddude said:

0.9.3.2 wallet fully synced in 2.5 hours.

Wallet sends and receives Feathercoins just fine :-)

here’s me tipping @Wellenreiter using 0.9.3.2
http://explorer.feathercoin.com/tx/ae7a76ea80f7f8b41c8be3fcb1850e7e0c4bf8d5cc2d9510740fc563107c0097#o0

I also did a comment to @Wellenreiter in this tx
http://explorer.feathercoin.com/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7#o1

Edit…I now know how to check for comments on the FTC block chain.

On my block explorer can see the transaction and I can copy and paste the OP_RETURN which was
49207265737065637420796f757220776f726b206475646521

http://fsight.chain.tips/tx/caa342e9f9ba290114f57186324c3882b411e3bc14fa4b5dff170d12cd401ce7

Hex to Ascii on OP_RETURN 49207265737065637420796f757220776f726b206475646521 = I respect your work dude!

We should try to find a way to detect commends in the BC, do the conversion automatically and display the comment in the GUI

I thought about this last night…it shouldnt be too hard with the Bitpay / Insight API - the OP_Return is already printed so some simple Javascript or PHP would do…

wrapper

Re : Feathercoin Wallet Advanced Features - Comments :

That’s great work. I can update the comment section of the guide with some help text.

We should ask @Lizhi, it may be a simple matter to “Report through” you comments
plus we need a simple comment decoder method.
Could the search for stealth coins be cloned to search for comments?

Without racking up dead coals, Is there any bounties left?.