[Dev] Release Candidate Feathercoin 0.9.3.2 - Check List

wrapper

AFB has done some additional icons. MultiSig, reports, connection status. MultiSig is a first draft.

Updated Icons Test

AcidD

so I’ve gotten to the point where the following tests are compiling…NOT passing…compiling…(i should go back and edit my previous posts…

  CXX      test_bitcoin-alert_tests.o
  CXX      test_bitcoin-allocator_tests.o
  CXX      test_bitcoin-base32_tests.o
  CXX      test_bitcoin-base58_tests.o
  CXX      test_bitcoin-base64_tests.o
  CXX      test_bitcoin-bignum_tests.o
  CXX      test_bitcoin-bloom_tests.o
  CXX      test_bitcoin-canonical_tests.o
  CXX      test_bitcoin-checkblock_tests.o
  CXX      test_bitcoin-Checkpoints_tests.o
  CXX      test_bitcoin-compress_tests.o
  CXX      test_bitcoin-DoS_tests.o
  CXX      test_bitcoin-getarg_tests.o
  CXX      test_bitcoin-key_tests.o
  CXX      test_bitcoin-main_tests.o
  CXX      test_bitcoin-miner_tests.o
  CXX      test_bitcoin-mruset_tests.o
  CXX      test_bitcoin-multisig_tests.o
  CXX      test_bitcoin-netbase_tests.o
  CXX      test_bitcoin-pmt_tests.o
  CXX      test_bitcoin-rpc_tests.o
  CXX      test_bitcoin-script_P2SH_tests.o
  CXX      test_bitcoin-script_tests.o
  CXX      test_bitcoin-serialize_tests.o
  CXX      test_bitcoin-sigopcount_tests.o
  CXX      test_bitcoin-test_bitcoin.o
  CXX      test_bitcoin-transaction_tests.o
  CXX      test_bitcoin-uint256_tests.o
  CXX      test_bitcoin-util_tests.o
  CXX      test_bitcoin-sighash_tests.o
  CXX      test_bitcoin-accounting_tests.o
  CXX      test_bitcoin-wallet_tests.o
  CXX      test_bitcoin-rpc_wallet_tests.o

when it comes time to test “feathercoin” … (it’s still referenced as “bitcoin”)

  CXXLD    test_bitcoin
test_bitcoin-base58_tests.o: In function `base58_tests::base58_keys_valid_parse::test_method()':
/home/aciddude/FTCNEW/Feathercoin/src/test/base58_tests.cpp:160: undefined reference to `CBitcoinSecret::GetPrivKey()'
/home/aciddude/FTCNEW/Feathercoin/src/test/base58_tests.cpp:161: undefined reference to `CBitcoinSecret::IsCompressed()'
test_bitcoin-DoS_tests.o: In function `DoS_tests::DoS_mapOrphans::test_method()':
/home/aciddude/FTCNEW/Feathercoin/src/test/DoS_tests.cpp:180: undefined reference to `AddOrphanTx(CTransaction const&)'
/home/aciddude/FTCNEW/Feathercoin/src/test/DoS_tests.cpp:197: undefined reference to `AddOrphanTx(CTransaction const&)'
/home/aciddude/FTCNEW/Feathercoin/src/test/DoS_tests.cpp:221: undefined reference to `AddOrphanTx(CTransaction const&)'
test_bitcoin-DoS_tests.o: In function `DoS_tests::DoS_checkSig::test_method()':
/home/aciddude/FTCNEW/Feathercoin/src/test/DoS_tests.cpp:258: undefined reference to `AddOrphanTx(CTransaction const&)'
test_bitcoin-key_tests.o: In function `key_tests::key_test1::test_method()':
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:73: undefined reference to `CBitcoinSecret::GetPrivKey()'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:79: undefined reference to `CBitcoinSecret::GetPrivKey()'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:121: undefined reference to `CPubKey::Verify(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&) const'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:122: undefined reference to `CPubKey::Verify(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&) const'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:123: undefined reference to `CPubKey::Verify(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&) const'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:124: undefined reference to `CPubKey::Verify(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&) const'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:126: undefined reference to `CPubKey::Verify(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&) const'
test_bitcoin-key_tests.o:/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:127: more undefined references to `CPubKey::Verify(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&) const' follow
test_bitcoin-key_tests.o: In function `key_tests::key_test1::test_method()':
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:152: undefined reference to `CPubKey::RecoverCompact(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&)'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:153: undefined reference to `CPubKey::RecoverCompact(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&)'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:154: undefined reference to `CPubKey::RecoverCompact(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&)'
/home/aciddude/FTCNEW/Feathercoin/src/test/key_tests.cpp:155: undefined reference to `CPubKey::RecoverCompact(uint256 const&, std::vector<unsigned char, std::allocator<unsigned char> > const&)'
collect2: error: ld returned 1 exit status
Makefile:789: recipe for target 'test_bitcoin' failed

The base 58 and key test stuff seems to be referencing changes I’ve made…the DoS Tests were not touched…

wrapper

It’s sensible to keep the core code the same, it just makes more work to go wrong. The test should be testing the core functionality.

Wellenreiter

I think, there have been changes in the procdure names of CBitcoinSecret, and you need to make these changes consistent in base58*.* and base58_tests*.*

By the way, can we split this thread in at least two ones?

Gui development
Test development/bug fixing

I have problems to follow the flow on the discussion in this long thread here, as Gui and test posts are mixed and the thread becomes very long

wrapper

@Wellenreiter You are right, we did keep them here for consistency, but this thread should be for raising new issues. I was just about to post the new design on a discussion thread.

I’ve extracted as much design work for the 0.9.3.2 beta test version from AFB as I can now anyway. Plus, we still have a few minor points to polish.

The main icons for the “Material Design set” are ready, which means I can continue working on getting screen shots for the Wallet Guide again.

Feathercoin-qt 0.9.3.2 Wallet operation guide
https://github.com/wrapperband/FeathercoinWalletGuide

Link to Discussion Thread.

AcidD

@Wellenreiter

I was thinking the same. In fact @wrapper and I discussed this last week or so.

I’ll make a new thread later on, I’ll reference this thread with some links and then carry on the log there.

wrapper

AFB and I are doing some re-sync blockchain from scratch tests on the new sync animation.

Anyway, for no good reason, i.e. software changes?, the syncing seems to have degenerated again.

Although in this case I removed a couple of blocks, so the blockchain re-indexed, then it stalled at 2 years, rescanning after the re-index. (so there could be a slightly different code path)

It got stuck at 325675

2 years 0 days

Debug log : on shut down :

2016-07-28 19:54:21 CSyncCheckpoint::ProcessSyncCheckpoint 140 ,AskFor.
2016-07-28 19:54:21 Receive checkpoint,hashCheckpoint=0000000000000000000000000000000000000000000000000000000000000000
.CSyncCheckpoint::ProcessSyncCheckpoint 100,hashCheckpoint=6491791a1d27e6f56ba0d93ef6a95d4cdb47cb2b769d4b7f2038a42ecbf2023b
2016-07-28 19:54:21 CSyncCheckpoint::ProcessSyncCheckpoint 110,mapBlockIndex.count=0
2016-07-28 19:54:21 CSyncCheckpoint::ProcessSyncCheckpoint 130: pending for sync-checkpoint 6491791a1d27e6f56ba0d93ef6a95d4cdb47cb2b769d4b7f2038a42ecbf2023b
2016-07-28 19:54:21 CSyncCheckpoint::ProcessSyncCheckpoint 140 ,AskFor.
2016-07-28 19:54:21 ProcessBlock: Preliminary checks
2016-07-28 19:54:21 ERROR: matches claimed amount, CheckProofOfWork() : hash doesn’t match nBits
2016-07-28 19:54:21 ProcessBlock() ProcessBlock: ORPHAN BLOCK 539, prev=73998e9aebc8d976d751c771ac769be0cbbd9f9d9b85a1f87690f8fc1c0f4

@Lizhi @Wellenreiter

wrapper

Just a note :
Status of Plugins:

Status of Bitmessage testing/guide production :

Not working under 16.04 - Still trying to get this going with a normal Bitmessage Linux install (i.e. Not installed but run from it’s own directory)

How does Bitmessage work under MS Windows? screen shot
Where do the files go , where is Bitmessage downloaded from?.
What is being passed to Bitmessage, what supposed to happen when bitmessage opens from the send menu right click

Wellenreiter has suggested adding a script file to /bin
if you create a shell script called pybitmessage under /usr/bin, make it executable, all should work

 whereis pybitmessage
 pybitmessage: /usr/bin/pybitmessage /usr/share/pybitmessage /usr/share/man/man1/pybitmessage.1.gz
 more /usr/bin/pybitmessage

 #!/bin/sh
  cd /usr/share/pybitmessage
  exec /usr/bin/python2 bitmessagemain.py

I don’t have those files :

This should have worked but doesn’t, I’m still checking what or if I did wrong /other ideas ie may work if copy over depends and include our own script file in Feathercoin root.

but mainly need to finish the guide.

whereis pybitmessage
pybitmessage: /bin/pybitmessage

#!/bin/sh
cd   /home/USER/programs/PyBitmessage/src
exec python /home/USER/programs/PyBitmessage/src/bitmessagemain.py  bitmessagemain.py

If we change the script can we send the message to Telegram (or such) instead?

The long term aim would be to make the plugins, at least, to have options check boxes to include on the menu.
A generic system where you can include additional plugins to run a script

Wellenreiter

@wrapper said in [Dev] Release Candidate Feathercoin 0.9.3.2 - Check List:

AFB and I are doing some re-sync blockchain from scratch tests on the new sync animation.

Anyway, for no good reason, i.e. software changes?, the syncing seems to have degenerated again.

Although in this case I removed a couple of blocks, so the blockchain re-indexed, then it stalled at 2 years, rescanning after the re-index. (so there could be a slightly different code path)

It got stuck at 325675

2 years 0 days

Debug log : on shut down :

2016-07-28 19:54:21 CSyncCheckpoint::ProcessSyncCheckpoint 140 ,AskFor.
2016-07-28 19:54:21 Receive checkpoint,hashCheckpoint=0000000000000000000000000000000000000000000000000000000000000000
.CSyncCheckpoint::ProcessSyncCheckpoint 100,hashCheckpoint=6491791a1d27e6f56ba0d93ef6a95d4cdb47cb2b769d4b7f2038a42ecbf2023b
2016-07-28 19:54:21 CSyncCheckpoint::ProcessSyncCheckpoint 110,mapBlockIndex.count=0
2016-07-28 19:54:21 CSyncCheckpoint::ProcessSyncCheckpoint 130: pending for sync-checkpoint 6491791a1d27e6f56ba0d93ef6a95d4cdb47cb2b769d4b7f2038a42ecbf2023b
2016-07-28 19:54:21 CSyncCheckpoint::ProcessSyncCheckpoint 140 ,AskFor.
2016-07-28 19:54:21 ProcessBlock: Preliminary checks
2016-07-28 19:54:21 ERROR: matches claimed amount, CheckProofOfWork() : hash doesn’t match nBits
2016-07-28 19:54:21 ProcessBlock() ProcessBlock: ORPHAN BLOCK 539, prev=73998e9aebc8d976d751c771ac769be0cbbd9f9d9b85a1f87690f8fc1c0f4

@Lizhi @Wellenreiter

The block number rings a bell. I think the last patch implemented into 0.9.3.x is mising in your version. It that possible?

wrapper

Hopefully it’s something like that. I thought I’d pulled any changes, I’ll let you know.

Explicitly use boost overloaded functions in base58 vector ?

Wellenreiter

regarding bitmessage:

exec python /home/USER/programs/PyBitmessage/src/bitmessagemain.py  bitmessagemain.py

should be

cd   /home/USER/programs/PyBitmessage/src
exec python bitmessagemain.py

assuming that bitmessagemain.py and the other .py files are in the directory /home/USER/programs/PyBitmessage/src

wrapper

@Wellenreiter I’ve done a git pull, It looks like I was up to date.

I will test a resync from the failed test with a rebuild

then if it still fails :
try a rebuild from scratch and see if it fails at the same place.

wrapper

Re:

Hurrahhh !!! !!!

wrapper

If we change the script can we send the message to Telegram (or such) instead?

A medium term fix would be to detect the BitMessage status and set the script or .bat file as part of the install.

The long term aim would be to make the plugins, at least, to have options check boxes to include on the menu.
A generic system where you can include additional plugins to run a script

wrapper

@Wellenreiter

cd   /home/USER/programs/PyBitmessage/src
exec python bitmessagemain.py
assuming that bitmessagemain.py and the other .py files are in the directory /home/USER/programs/PyBitmessage/src

That isn’t working on drop down test to pass anything through to Bitmessage, I think we need to create a pass through variable? probably text.

wrapper

I tried this in the script :

exec python bitmessagemain.py $1

Transaction Grid Right Click - that didn’t work for me. the right click doesn’t open BitMessage either.

lizhi

Great work wrapper, Can you push your codes and images to github ?

wrapper

@Lizhi : All the new Icons and dev changes are on on http://github.com/wrapperband/Feathercoin.git

AFB is having a look at the splash screen, we have just found how to make the animation movie, by using the make_spinner.py python script in Feathercoin/share/qt to make the png spinner files .

We are looking at what the windows script make_windows_icon.sh in the same directory, to see if that needs regenerating before the final beta test version.

When Wellenreiter is ready we will pull them into FTC version.

~~Sync issues : Possibly missing Patch - Re Testing Re-Synchronisation from install :~~ Passed + very fast.

wrapper

Thanks to AFB, here’s the new splashscreen in action …

Splashscreen FTC wallet 0.9.6

AcidD

when is AFB gonna get an account so we can start giving Kudos ?! Great work!