Forum Home
    • Register
    • Login
    • Search
    • Recent
    • Tags
    • Popular

    Github help

    Off-Topic
    2
    12
    3976
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • AmDD
      AmDD Regular Member last edited by

      haha, Im sorry but thats no help to me at all! :) I know literally zero about Github, how it works or what its for really.

      If you look at that link in the OP and click Pull Request to the right there are modified files that other people have somehow uploaded. I want to do that. I dont think its merging into his code but I guess its not under my own account either… Basically, I added a Feathercoin option to his site and Id like to share it but I dont know the best way to do this. Id like to still give him full credit for creating 99.9% of the code, All I did was add about 10 lines to it.

      EDIT: PS, thanks for the reply. Sorry I just dont know what Im doing.

      P2Pool Node: http://104.236.34.9:19327/ 0.5% fee

      1 Reply Last reply Reply Quote 0
      • kris_davison
        kris_davison last edited by

        Hey that’s OK I’m a github newbie too I’ve only ever cloned other peoples code or added my own.
        I think the steps may be similar for a pull request. Do you have git installed on your PC? Are you on Linux or windows? I’ll have a read see what’s needed. :)

        1 Reply Last reply Reply Quote 0
        • kris_davison
          kris_davison last edited by

          Looks like the first thing you need to do is create a branch of his code. You can do this from there github repository on the website. As seen in this link.

          https://help.github.com/articles/creating-and-deleting-branches-within-your-repository/#creating-a-branch

          A branch is just a copy of all there code that you can change.

          1 Reply Last reply Reply Quote 0
          • kris_davison
            kris_davison last edited by

            Then follow the instructions in my original post but on your branch.

            Cloning will copy all the code to your PC
            Then you will need to change the file with 10 lines as you said before
            Then add your file with git add
            Then push your changes back up to github

            1 Reply Last reply Reply Quote 0
            • kris_davison
              kris_davison last edited by

              Last thing is to create a pull request. That is just a request that they review and potentially add the differences between your version of the code and Thiers. Here is a walk through link

              https://help.github.com/articles/creating-and-deleting-branches-within-your-repository/#creating-a-branch

              1 Reply Last reply Reply Quote 0
              • AmDD
                AmDD Regular Member last edited by

                Hey that’s OK I’m a github newbie too I’ve only ever cloned other peoples code or added my own.
                I think the steps may be similar for a pull request. Do you have git installed on your PC? Are you on Linux or windows? I’ll have a read see what’s needed. :)

                haha good, I feel really dumb that I cant work a simple website. lol

                I have windows, didnt know there was anything to install…

                I’ll give this a try and see what I can come up with. The guy told me he would review my code to make sure its correct. I hope he double checks to make sure I didnt add anything “extra”.

                Thanks for the help, as always!

                P2Pool Node: http://104.236.34.9:19327/ 0.5% fee

                1 Reply Last reply Reply Quote 0
                • kris_davison
                  kris_davison last edited by

                  Ah if its windows it should be very similar but you will have to install git. Git is just a source repository a bit like svn but the difference is you create a local repository and make your changes there then push them to another person or github or bitbucket.

                  I think there is a windows installer of git.

                  In fact I’ve just found a github GUI for windows that might help?

                  https://windows.github.com/

                  Let me know how you get on.

                  1 Reply Last reply Reply Quote 0
                  • AmDD
                    AmDD Regular Member last edited by

                    Ok, so I admit defeat.

                    I have no idea what Im doing… I installed the program and was able to upload all the files to my own account on Github but i dont think thats what I wanted to do.

                    I think I’ll just start a thread explaining how to change the code and upload the images allowing others to make the changes themselves.

                    thanks for the help tho, Kris!

                    P2Pool Node: http://104.236.34.9:19327/ 0.5% fee

                    1 Reply Last reply Reply Quote 0
                    • kris_davison
                      kris_davison last edited by

                      no problem I can always try and do it for you once you have posted the changes but I’ll try to make the point that I should not be given the credit for the work :)

                      1 Reply Last reply Reply Quote 0
                      • AmDD
                        AmDD Regular Member last edited by

                        Forum post: https://forum.feathercoin.com/index.php?/topic/8321-ftc-paper-wallet/#entry72126

                        My attempt at Github: https://github.com/AmDDJunkie/BTCPaperWallet

                        P2Pool Node: http://104.236.34.9:19327/ 0.5% fee

                        1 Reply Last reply Reply Quote 0
                        • First post
                          Last post