[Dev] Feathercoin 0.11.x Intergration, Testing and Building

Bushstar

BIP 66 was added to 0.11 but in 0.8/0.9 it was added to memory pool, this change was not applied to 0.11. I’ve set this change in the following commit.

https://github.com/FeatherCoin/Feathercoin/commit/e42f790b6039ecdb120932acb772c176fb2c0513

The switch time here is redundant as v4 does not yet have consensus.

https://github.com/FeatherCoin/Feathercoin/commit/0220702e993d462130aa34d6892a0fdfddfcab97

BIP66 is active, I trust the height set is in line with when Ghost added it to 0.8, I think we are somewhat safe on this anyway. Also 0.11 set BIP66 and BIP65 to be active at the same time, BIP66 is active but BIP65 should only be active once we have miner support.

https://github.com/FeatherCoin/Feathercoin/commit/e4ecf654aba6a552d6901dc6f493aa91674ce05b

Reject v2 when v4 is 95%, this code was already in there but here I’ve updated the code from v3 to v4 as v3 is always rejected.

https://github.com/FeatherCoin/Feathercoin/commit/b7c627b34d096f702418aab24d8192020c3dd5ec

Here I’ve removed the code for rejecting v3 at 95% as it is already rejected.

https://github.com/FeatherCoin/Feathercoin/commit/2f0603a051f6b062c4d04a3aba6b61907478991a

Do we need cVersion in the code and what do we need it for?

As the majority of the network is nVersion 2 blocks we can stick to nVersion 4 to soft fork BIP65.

wrapper

Cheers @Bushstar I’ve run a build test. We should be back to having auto test builds when @Cookieboy gets back.

wrapper

Review of usage of OpenSSL

Like Litecoin FTC will need to retain the use of OpenSSL, it is used in ACP, Stealth and scrypt Functionality.

Note: Good point, Litecoin did add SSL for Scrypt, check the commit on Litecoin 0.14.

@Bushstar

https://github.com/litecoin-project/litecoin/commit/0c3edb9f1991508a26c7ee5865a0fd9c9df430ac

wrapper

Notes on 0.11.2

This check on the v4 block time is redundant as there is also a IsSuperMajority check that is not going to return true, not even yet.

https://github.com/FeatherCoin/Feathercoin/blob/0.11.2/src/main.cpp#L3226

So we have cVersion and nVersion.

If we soft fork BIP65 and set BIP66 to activate at a set height then we do not really need cVersion.

Ghost’s BIP66 Strict DER code is in 0.11 however Lizhi did not add it to AcceptToMemoryPool, it might be because it is different than before, in 0.9 it was in the Accept function. I’ve added it to 0.11 and will document.

This was missed out.

https://github.com/FeatherCoin/Feathercoin/commit/e42f790b6039ecdb120932acb772c176fb2c0513

Checkpointsync does not seem to use the testnet key, just the mainnet key.

Wellenreiter

@wrapper said in [Dev] Feathercoin 0.11.x Intergration, Testing and Building:

Checkpointsync does not seem to use the testnet key, just the mainnet key.

Correct!
ACP never was implemented for the testnet.

wrapper

0.11.2 Synchronisation speed Test

Before Debug message review : Sync completed in 3.5 Hours.
After Debug message review stage 1: Sync completed in 2.75 Hours.
After Debug message review stage 2: Sync completed in 2.70 Hours
After Debug message review stage 3: Sync completed in 2.57 Hours
After Debug message review stage 4: Sync completed in 3.02 Hours
After Debug message review stage 5 with -debug : Sync completed in 4.15 Hours

0.11.2 sync speed

Blocks against time

0.11.2 sync speed

wrapper

0.11.2 settings. Test

Test changing max outbound connections

Test upping default from lowly 8 to more reasonable 10

net.cpp

static const int MAX_OUTBOUND_CONNECTIONS = 10;

1st test :

Up from 125 to 150:
int nMaxConnections = 150;

LTC also recommends 1000MB max dbcache. Testing increase min from 4 to 10.

src/txdb.h

 // -dbcache default (MiB)
static const int64_t nDefaultDbCache = 100;
// max. -dbcache in (MiB)
static const int64_t nMaxDbCache = sizeof(void*) > 4 ? 4096 : 1024;
 // min. -dbcache in (MiB)
static const int64_t nMinDbCache = 4;

wrapper

Just found this is it worth adding to FTCseeder?

Plus, these available updates : https://github.com/wrapperband/feathercoin-seeder/compare/master...sipa:master

Poll nodes for new IPs at 1 hour instead of 1 week intervals.
https://github.com/keremhd/mintcoin-seeder/commit/5ed3743143c8a2da024f32b8845d718fe0f357ea

Feathercoin-seeder , see @wellenreiter has contributed.

https://github.com/FeatherCoin/feathercoin-seeder

wrapper

Note : is www.showmyip.com in 0.11.2? : https://forum.feathercoin.com/topic/8931/dev-documenting-feathercoin-specific-software-settings-part-2/32

www.showmyip.com is very slow / not working. www.showmyip.net worked fine though.

wrapper

There are a couple of functions to be added back in for ACP, IsInMainChain, GetTotalBlocksEstimate, SetBestChain and PushGetBlocks.